[evolution] Simplify em_config_target_new_account_update_settings().



commit be48e719400661da517fb0d8a570053af15c2c18
Author: Matthew Barnes <mbarnes redhat com>
Date:   Tue Aug 16 11:34:08 2011 -0400

    Simplify em_config_target_new_account_update_settings().
    
    Just connect to the "notify" signal, without the detail.  That will
    trigger the callback when any property changes, which seems to be the
    intent there.

 mail/em-config.c |   20 ++++----------------
 1 files changed, 4 insertions(+), 16 deletions(-)
---
diff --git a/mail/em-config.c b/mail/em-config.c
index 3f649ba..464c9d8 100644
--- a/mail/em-config.c
+++ b/mail/em-config.c
@@ -254,20 +254,8 @@ em_config_target_new_account_update_settings (EConfig *ep, EMConfigTargetAccount
 
 	target->settings = settings;
 
-	if (target->settings != NULL) {
-		GParamSpec **params;
-		guint n_params = 0;
-
-		params = camel_settings_class_list_settings (CAMEL_SETTINGS_GET_CLASS (target->settings), &n_params);
-		if (params) {
-			guint ii;
-			gchar *sig_name;
-
-			for (ii = 0; ii < n_params; ii++) {
-				sig_name = g_strconcat ("notify::", params[ii]->name, NULL);
-				g_signal_connect (target->settings, sig_name, G_CALLBACK (emp_account_changed), ep);
-				g_free (sig_name);
-			}
-		}
-	}
+	if (target->settings != NULL)
+		g_signal_connect (
+			target->settings, "notify",
+			G_CALLBACK (emp_account_changed), ep);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]