[glibmm] giomm: Application: local_command_line_vfunc(): Use references for parameters.



commit 3a8b1625613e10f38f001e984d91f3c36a48cf52
Author: Murray Cumming <murrayc murrayc com>
Date:   Wed Aug 3 09:18:10 2011 +0200

    giomm: Application: local_command_line_vfunc(): Use references for parameters.
    
    * gio/src/application.hg: Use references instead of pointers, now that
    we know how these paramters are actually used. See bug #643478.

 ChangeLog              |    7 +++++++
 gio/src/application.hg |    6 +++---
 2 files changed, 10 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 017c076..efc12be 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-08-03  Murray Cumming  <murrayc murrayc com>
 
+	giomm: Application: local_command_line_vfunc(): Use references for parameters.
+
+	* gio/src/application.hg: Use references instead of pointers, now that 
+	we know how these paramters are actually used. See bug #643478.
+
+2011-08-03  Murray Cumming  <murrayc murrayc com>
+
 	Add back Gio::Application and friends so we can try to finish them.
 
 	* gio/src/actiongroup.[hg|ccg]:
diff --git a/gio/src/application.hg b/gio/src/application.hg
index 7559525..571042e 100644
--- a/gio/src/application.hg
+++ b/gio/src/application.hg
@@ -190,9 +190,9 @@ protected:
   _POP()
 #m4end
 
-  //TODO: Change the parameter types when we know how they are really used.
-  //See https://bugzilla.gnome.org/show_bug.cgi?id=643478
-  _WRAP_VFUNC(bool local_command_line(gchar*** arguments, int* exit_status), local_command_line)
+#m4 _CONVERSION(`char**&', `gchar***',`&($3)')
+#m4 _CONVERSION(`gchar***', `char**&',`*($3)')
+  _WRAP_VFUNC(bool local_command_line(char**& arguments, int& exit_status), local_command_line)
   
 /* TODO:
   void                      (* before_emit)         (GApplication              *application,



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]