[tracker/tracker-0.10] libtracker-data: Set errors in these two fatal cases
- From: Martyn James Russell <mr src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [tracker/tracker-0.10] libtracker-data: Set errors in these two fatal cases
- Date: Thu, 28 Apr 2011 11:11:32 +0000 (UTC)
commit f844142154c273e299e26bcc72d406a10a3183a8
Author: Philip Van Hoof <philip codeminded be>
Date: Wed Apr 27 12:10:09 2011 +0200
libtracker-data: Set errors in these two fatal cases
src/libtracker-data/tracker-db-journal.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
---
diff --git a/src/libtracker-data/tracker-db-journal.c b/src/libtracker-data/tracker-db-journal.c
index 526cd7c..31bf0da 100644
--- a/src/libtracker-data/tracker-db-journal.c
+++ b/src/libtracker-data/tracker-db-journal.c
@@ -482,8 +482,9 @@ db_journal_init_file (JournalWriter *jwriter,
/* If it didn't expand properly */
if (jwriter->cur_block == NULL) {
- /* Q: Should we set error with out of memory here? When adding error
- * reporting there where no warnings or criticals here. */
+ g_set_error (error, TRACKER_DB_JOURNAL_ERROR,
+ TRACKER_DB_JOURNAL_ERROR_COULD_NOT_WRITE,
+ "Could not write journal, not enough memory");
g_free (jwriter->journal_filename);
jwriter->journal_filename = NULL;
return FALSE;
@@ -499,9 +500,10 @@ db_journal_init_file (JournalWriter *jwriter,
jwriter->cur_block[7] = '4';
if (!write_all_data (jwriter->journal, jwriter->cur_block, 8)) {
- /* Q: Can't write 8 bytes to the file, should we set error with out
- * of diskspace here? When adding error reporting there where no
- * warnings or criticals here. */
+ g_set_error (error, TRACKER_DB_JOURNAL_ERROR,
+ TRACKER_DB_JOURNAL_ERROR_COULD_NOT_WRITE,
+ "Could not write to journal file, %s",
+ g_strerror (errno));
g_free (jwriter->journal_filename);
jwriter->journal_filename = NULL;
return FALSE;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]