[empathy] contact_list_store_chat_state_changed_cb(): tidy



commit 3e34b40f5a2ce026187c2e9c8316f1b255c193e9
Author: Will Thompson <will thompson collabora co uk>
Date:   Fri Apr 15 19:31:28 2011 +0100

    contact_list_store_chat_state_changed_cb(): tidy
    
    This doesn't fix bgo#647891, but I think it makes the loop clearer.
    
    Reviewed-by: Guillaume Desmottes <guillaume desmottes collabora co uk>

 libempathy-gtk/empathy-contact-list-store.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)
---
diff --git a/libempathy-gtk/empathy-contact-list-store.c b/libempathy-gtk/empathy-contact-list-store.c
index f6a7a11..783ce77 100644
--- a/libempathy-gtk/empathy-contact-list-store.c
+++ b/libempathy-gtk/empathy-contact-list-store.c
@@ -194,17 +194,15 @@ contact_list_store_chat_state_changed_cb (TpChannel *self,
 
 	contacts = empathy_contact_list_get_members (priv->list);
 
-	/* Find the contact in the list. After that l is the list elem or NULL */
 	for (l = contacts; l != NULL; l = l->next) {
-		if (empathy_contact_get_handle (EMPATHY_CONTACT (l->data)) ==
-		    contact_handle) {
+		EmpathyContact *contact = EMPATHY_CONTACT (l->data);
+
+		if (empathy_contact_get_handle (contact) == contact_handle) {
+			contact_list_store_contact_update (store, contact);
 			break;
 		}
 	}
 
-	if (l != NULL)
-		contact_list_store_contact_update (store, l->data);
-
 	g_list_foreach (contacts, (GFunc) g_object_unref, NULL);
 	g_list_free (contacts);
 }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]