[glib] testutils: Return a boolean from g_test_case_run()
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] testutils: Return a boolean from g_test_case_run()
- Date: Mon, 18 Apr 2011 15:09:02 +0000 (UTC)
commit 19fdb18ef8794bde6b29e400a6d868a7974b73e2
Author: Benjamin Otte <otte redhat com>
Date: Mon Apr 18 14:35:58 2011 +0200
testutils: Return a boolean from g_test_case_run()
Return value is intened to be TRUE for success, FALSE for failure.
Currently we return TRUE all the time.
Previously the test returned 0 all the time.
glib/gtestutils.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/glib/gtestutils.c b/glib/gtestutils.c
index c5754ec..7488ec3 100644
--- a/glib/gtestutils.c
+++ b/glib/gtestutils.c
@@ -1146,7 +1146,7 @@ g_test_queue_destroy (GDestroyNotify destroy_func,
test_destroy_queue = dentry;
}
-static int
+static gboolean
test_case_run (GTestCase *tc)
{
gchar *old_name = test_run_name, *old_base = g_strdup (test_uri_base);
@@ -1195,7 +1195,7 @@ test_case_run (GTestCase *tc)
test_run_name = old_name;
g_free (test_uri_base);
test_uri_base = old_base;
- return 0;
+ return TRUE;
}
static int
@@ -1220,7 +1220,8 @@ g_test_run_suite_internal (GTestSuite *suite,
if (l == n && strncmp (path, tc->name, n) == 0)
{
n_good++;
- n_bad += test_case_run (tc) != 0;
+ if (!test_case_run (tc))
+ n_bad++;
}
}
g_slist_free (reversed);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]