[yelp] yelp-location-entry: Don't use image-loading when loading, for now



commit 8603ba3a1042e962cbc70e3a1c769f7bfc78e404
Author: Shaun McCance <shaunm gnome org>
Date:   Sat Apr 16 13:29:46 2011 -0400

    yelp-location-entry: Don't use image-loading when loading, for now
    
    The non-symbolic looks out of place with the symbolic page icons. GtkEntry
    also doesn't properly do symbolic icons, so setting it to the (non-existant)
    image-loading-symbolic causes a broken image icon.

 libyelp/yelp-location-entry.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/libyelp/yelp-location-entry.c b/libyelp/yelp-location-entry.c
index f4c1ea0..493dab2 100644
--- a/libyelp/yelp-location-entry.c
+++ b/libyelp/yelp-location-entry.c
@@ -795,9 +795,14 @@ location_entry_set_entry (YelpLocationEntry *entry, gboolean emit)
                             HISTORY_COL_PAGE, &page_id,
                             -1);
         if (flags & LOCATION_ENTRY_IS_LOADING) {
+            /* Would be nice to have a "loading" icon. I was using image-loading,
+             * but it look out of place with symbolic page icons. Plus, using
+             * image-loading-symbolic shows a broken image, because GtkEntry
+             * doesn't correctly use symbolic icons as of GNOME 3.0.
+             */
             gtk_entry_set_icon_from_icon_name (GTK_ENTRY (priv->text_entry),
                                                GTK_ENTRY_ICON_PRIMARY,
-                                               "image-loading-symbolic");
+                                               "yelp-page-symbolic");
             if (priv->pulse > 0)
                 g_source_remove (priv->pulse);
             priv->pulse = g_timeout_add (80, location_entry_pulse, entry);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]