[gtk+/parser: 52/57] cssprovider: Emit a g_warning() when a css file is erroneous



commit 26d7b2e79f675c77b3ff5ea3242b4abf411015f1
Author: Benjamin Otte <otte redhat com>
Date:   Mon Apr 11 01:51:49 2011 +0200

    cssprovider: Emit a g_warning() when a css file is erroneous
    
    ... and no other error handler is active. See the source code comment
    for the reasoning.

 gtk/gtkcssprovider.c |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
---
diff --git a/gtk/gtkcssprovider.c b/gtk/gtkcssprovider.c
index 31fe565..bc85de4 100644
--- a/gtk/gtkcssprovider.c
+++ b/gtk/gtkcssprovider.c
@@ -876,6 +876,20 @@ gtk_css_provider_parsing_error (GtkCssProvider  *provider,
       priv->error = g_error_copy (error);
       g_prefix_error (&priv->error, "%s:%u:%u: ", path ? path : "<unknown>", line, position);
     }
+
+  /* Only emit a warning when we have no error handlers. This is our
+   * default handlers. And in this case erroneous CSS files are a bug
+   * and should be fixed.
+   * Note that these warnings can also be triggered by a broken theme
+   * that people installed from some weird location on the internets.
+   */
+  if (!g_signal_has_handler_pending (provider,
+                                     css_provider_signals[PARSING_ERROR],
+                                     0,
+                                     TRUE))
+    {
+      g_warning ("Theme parsing error: %s:%u:%u: %s", path ? path : "<unknown>", line, position, error->message);
+    }
 }
 
 static void



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]