[folks] Turn on valac warnings for the KeyFile backend.
- From: Travis Reitter <treitter src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [folks] Turn on valac warnings for the KeyFile backend.
- Date: Mon, 27 Sep 2010 21:33:56 +0000 (UTC)
commit 81552a6128d13627ce3e0b2526070dc7af17db5e
Author: Travis Reitter <travis reitter collabora co uk>
Date: Mon Sep 27 12:01:00 2010 -0700
Turn on valac warnings for the KeyFile backend.
backends/key-file/Makefile.am | 1 +
backends/key-file/kf-backend-factory.vala | 10 +---------
configure.ac | 2 ++
3 files changed, 4 insertions(+), 9 deletions(-)
---
diff --git a/backends/key-file/Makefile.am b/backends/key-file/Makefile.am
index 7552230..cf42937 100644
--- a/backends/key-file/Makefile.am
+++ b/backends/key-file/Makefile.am
@@ -6,6 +6,7 @@ AM_CPPFLAGS = \
$(NULL)
VALAFLAGS += \
+ $(ERROR_VALAFLAGS) \
--vapidir=. \
--vapidir=$(top_srcdir)/folks \
$(addprefix --pkg ,$(folks_backend_key_file_deps)) \
diff --git a/backends/key-file/kf-backend-factory.vala b/backends/key-file/kf-backend-factory.vala
index 8343c28..104d883 100644
--- a/backends/key-file/kf-backend-factory.vala
+++ b/backends/key-file/kf-backend-factory.vala
@@ -54,14 +54,6 @@ public class Folks.Backends.Kf.BackendFactory : Object
*/
public BackendFactory (BackendStore backend_store)
{
- try
- {
- backend_store.add_backend (new Backend ());
- }
- catch (GLib.Error e)
- {
- warning ("Failed to add key file backend to libfolks: %s",
- e.message);
- }
+ backend_store.add_backend (new Backend ());
}
}
diff --git a/configure.ac b/configure.ac
index 358d715..97dc88b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -176,6 +176,7 @@ m4_if(folks_released, [1], [],
[
ERROR_INTROSPECTION_SCANNER_ARGS="$ERROR_INTROSPECTION_SCANNER_ARGS \
--warn-error"
+ ERROR_VALAFLAGS="$ERROR_VALAFLAGS --fatal-warnings"
if test x$werror = xyes; then
ERROR_CFLAGS="$ERROR_CFLAGS -Werror"
fi
@@ -198,6 +199,7 @@ AS_COMPILER_FLAG([-Wstrict-prototypes], [ERROR_CFLAGS="$ERROR_CFLAGS \
-Wstrict-prototypes"])
AC_SUBST([ERROR_INTROSPECTION_SCANNER_ARGS])
+AC_SUBST([ERROR_VALAFLAGS])
AC_SUBST([ERROR_CFLAGS])
# -----------------------------------------------------------
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]