[gnote] Do not initialize NoteOfTheDayAddin on create
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnote] Do not initialize NoteOfTheDayAddin on create
- Date: Sun, 26 Sep 2010 12:51:33 +0000 (UTC)
commit 19aba9d71a55cc8eea7a0b56d79587a0b94eaeb9
Author: Å?ukasz Krotowski <lukasz krotowski gmail com>
Date: Sun Sep 26 14:44:00 2010 +0300
Do not initialize NoteOfTheDayAddin on create
1) It pretty much defeats purpose of storing disabled status in
configuration file.
2) When started disabled it caused segfault because m_manager was
NULL. It was caused by the fact that the first initialize() call was
called when Gnote::obj().default_note_manager() == NULL.
If add-in was reinitialized m_manager was overwritten with correct
value and delayed work in check_new_day() accessed not-null m_manager.
.../noteoftheday/noteofthedayapplicationaddin.cpp | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
---
diff --git a/src/addins/noteoftheday/noteofthedayapplicationaddin.cpp b/src/addins/noteoftheday/noteofthedayapplicationaddin.cpp
index 1610262..11b2f4f 100644
--- a/src/addins/noteoftheday/noteofthedayapplicationaddin.cpp
+++ b/src/addins/noteoftheday/noteofthedayapplicationaddin.cpp
@@ -69,7 +69,6 @@ NoteOfTheDayApplicationAddin::NoteOfTheDayApplicationAddin()
, m_manager(0)
, m_timeout()
{
- initialize();
}
NoteOfTheDayApplicationAddin::~NoteOfTheDayApplicationAddin()
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]