[pitivi] Some cleanup in effect testing



commit 40f9e823218f137a625a1031d62a35d4968f25e5
Author: Thibault Saunier <tsaunier gnome org>
Date:   Sun Aug 8 20:55:39 2010 -0400

    Some cleanup in effect testing

 pitivi/timeline/track.py    |    3 +--
 tests/test_timeline_undo.py |    4 +---
 2 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/pitivi/timeline/track.py b/pitivi/timeline/track.py
index b9fa3de..1336a61 100644
--- a/pitivi/timeline/track.py
+++ b/pitivi/timeline/track.py
@@ -749,8 +749,7 @@ class TrackEffect(TrackObject):
         #Should we find a better implementation?
         for element in self.gnl_object.recurse():
             if self.factory.name in element.get_name():
-                break
-        return element
+                return element
 
 class Transition(Signallable):
 
diff --git a/tests/test_timeline_undo.py b/tests/test_timeline_undo.py
index 0e9655a..bf649d5 100644
--- a/tests/test_timeline_undo.py
+++ b/tests/test_timeline_undo.py
@@ -203,8 +203,6 @@ class  TestTimelineUndo(TestCase):
                 in self.track1.track_objects)
 
         self.action_log.redo()
-        self.failUnless(self.track_effect1 \
-                in self.timeline_object1.track_objects)
         self.failUnless(len([effect for effect in
                                 self.timeline_object1.track_objects
                                 if isinstance(effect, TrackEffect)]) == 1)
@@ -223,7 +221,7 @@ class  TestTimelineUndo(TestCase):
         self.timeline_object1.addTrackObject(self.track_effect1)
         self.track1.addTrackObject(self.track_effect1)
 
-        self.action_log.begin("add effect")
+        self.action_log.begin("remove effect")
         self.timeline_object1.removeTrackObject(self.track_effect1)
         self.track1.removeTrackObject(self.track_effect1)
         self.action_log.commit()



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]