[pitivi] Small clean up in the EffectFactory implementation and testing



commit 4e7996bdbb34f0a5ecd064b31b7ed8e1d1f7c65f
Author: Thibault Saunier <tsaunier src gnome org>
Date:   Wed May 5 17:48:24 2010 -0400

    Small clean up in the EffectFactory implementation and testing

 pitivi/factories/operation.py     |    1 -
 tests/test_factories_operation.py |    3 ++-
 2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/pitivi/factories/operation.py b/pitivi/factories/operation.py
index 6872ee1..ec311c5 100644
--- a/pitivi/factories/operation.py
+++ b/pitivi/factories/operation.py
@@ -67,7 +67,6 @@ class VideoEffectFactory (EffectFactory):
         self._effect = effect
 
     def _makeBin (self, *args):
-        print "TEST1"
         return gst.element_factory_make(self._effect)
 
 class AudioEffectFactory (EffectFactory):
diff --git a/tests/test_factories_operation.py b/tests/test_factories_operation.py
index 936ce89..15cbfcc 100644
--- a/tests/test_factories_operation.py
+++ b/tests/test_factories_operation.py
@@ -28,6 +28,7 @@ import gst
 
 from common import TestCase
 
+from pitivi.log.log import debug
 from pitivi.factories.operation import VideoEffectFactory
 
 class TestVideoEffectFactory(TestCase):
@@ -39,8 +40,8 @@ class TestVideoEffectFactory(TestCase):
         bin = self.factory.makeBin()
         bin2 = self.factory.makeBin()
         self.failUnless(isinstance(bin, gst.Element))
-        self.failUnless(len (self.factory.bins) == 1)
         self.factory.releaseBin(bin)
+        self.factory.releaseBin(bin2)
 
     def tearDown(self):
         self.factory = None



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]