[gnome-control-center] default-apps: Fix illegal memory access



commit a205fc79b4f7d2b00d3fea940d345a0d2244026c
Author: Bastien Nocera <hadess hadess net>
Date:   Tue Sep 21 15:22:43 2010 +0100

    default-apps: Fix illegal memory access
    
    gnome_da_xml_free() frees priv->capplet, so we shouldn't be
    accessing it afterwards.

 .../cc-default-applications-panel.c                |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/panels/default-applications/cc-default-applications-panel.c b/panels/default-applications/cc-default-applications-panel.c
index a86ffca..f840152 100644
--- a/panels/default-applications/cc-default-applications-panel.c
+++ b/panels/default-applications/cc-default-applications-panel.c
@@ -71,7 +71,6 @@ cc_default_applications_panel_dispose (GObject *object)
   if (priv->capplet)
     {
       g_object_unref (priv->capplet->gconf);
-      gnome_da_xml_free (priv->capplet);
 
       if (priv->capplet->theme_changed_id > 0)
         {
@@ -80,6 +79,8 @@ cc_default_applications_panel_dispose (GObject *object)
           priv->capplet->theme_changed_id = 0;
         }
 
+      gnome_da_xml_free (priv->capplet);
+
       priv->capplet = NULL;
     }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]