[evolution-data-server/gnome-2-32] Bug 630135 - No UI feedback when imapx connection fails
- From: David Woodhouse <dwmw2 src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server/gnome-2-32] Bug 630135 - No UI feedback when imapx connection fails
- Date: Tue, 21 Sep 2010 22:30:13 +0000 (UTC)
commit 3ff43587fdc5827efcd93e3e5cd5886c8700de7c
Author: David Woodhouse <David Woodhouse intel com>
Date: Mon Sep 20 11:25:10 2010 +0100
Bug 630135 - No UI feedback when imapx connection fails
Don't call camel_operation_cancel(NULL). That has undesired effects.
Only call camel_operation_cancel(server->op) if it's non-NULL -- i.e. if the
parser thread had actually started up and set it.
camel/providers/imapx/camel-imapx-server.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index 233e185..2cc5bd2 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -4756,7 +4756,8 @@ imapx_server_dispose (GObject *object)
QUEUE_UNLOCK(server);
server->parser_quit = TRUE;
- camel_operation_cancel (server->op);
+ if (server->op)
+ camel_operation_cancel (server->op);
if (server->parser_thread)
g_thread_join (server->parser_thread);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]