[vala] Port remaining code nodes to use accept_children for visiting children
- From: Jürg Billeter <juergbi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [vala] Port remaining code nodes to use accept_children for visiting children
- Date: Fri, 10 Sep 2010 15:37:27 +0000 (UTC)
commit 6ecef92625b90c80a02d52b06a648b14bbc8e890
Author: Luca Bruno <lethalman88 gmail com>
Date: Thu Jun 3 10:32:31 2010 +0200
Port remaining code nodes to use accept_children for visiting children
Fixes bug 566870.
vala/valaaddressofexpression.vala | 6 ++++--
vala/valacastexpression.vala | 10 ++++++----
vala/valaconditionalexpression.vala | 10 ++++++----
vala/valapostfixexpression.vala | 6 ++++--
vala/valasizeofexpression.vala | 6 ++++--
vala/valasymbolresolver.vala | 28 ++++++++++++++++++++++++++++
vala/valatypecheck.vala | 10 ++++++----
vala/valatypeofexpression.vala | 6 ++++--
8 files changed, 62 insertions(+), 20 deletions(-)
---
diff --git a/vala/valaaddressofexpression.vala b/vala/valaaddressofexpression.vala
index c6804d6..cda53ed 100644
--- a/vala/valaaddressofexpression.vala
+++ b/vala/valaaddressofexpression.vala
@@ -53,13 +53,15 @@ public class Vala.AddressofExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
- inner.accept (visitor);
-
visitor.visit_addressof_expression (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ inner.accept (visitor);
+ }
+
public override void replace_expression (Expression old_node, Expression new_node) {
if (inner == old_node) {
inner = new_node;
diff --git a/vala/valacastexpression.vala b/vala/valacastexpression.vala
index 536fe14..7018992 100644
--- a/vala/valacastexpression.vala
+++ b/vala/valacastexpression.vala
@@ -81,14 +81,16 @@ public class Vala.CastExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
+ visitor.visit_cast_expression (this);
+
+ visitor.visit_expression (this);
+ }
+
+ public override void accept_children (CodeVisitor visitor) {
inner.accept (visitor);
if (!is_non_null_cast) {
type_reference.accept (visitor);
}
-
- visitor.visit_cast_expression (this);
-
- visitor.visit_expression (this);
}
public override void replace_expression (Expression old_node, Expression new_node) {
diff --git a/vala/valaconditionalexpression.vala b/vala/valaconditionalexpression.vala
index 6c7e8d6..25c3e27 100644
--- a/vala/valaconditionalexpression.vala
+++ b/vala/valaconditionalexpression.vala
@@ -85,15 +85,17 @@ public class Vala.ConditionalExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
- condition.accept (visitor);
- true_expression.accept (visitor);
- false_expression.accept (visitor);
-
visitor.visit_conditional_expression (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ condition.accept (visitor);
+ true_expression.accept (visitor);
+ false_expression.accept (visitor);
+ }
+
public override bool is_pure () {
return condition.is_pure () && true_expression.is_pure () && false_expression.is_pure ();
}
diff --git a/vala/valapostfixexpression.vala b/vala/valapostfixexpression.vala
index ee53151..57969b0 100644
--- a/vala/valapostfixexpression.vala
+++ b/vala/valapostfixexpression.vala
@@ -51,13 +51,15 @@ public class Vala.PostfixExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
- inner.accept (visitor);
-
visitor.visit_postfix_expression (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ inner.accept (visitor);
+ }
+
public override bool is_pure () {
return false;
}
diff --git a/vala/valasizeofexpression.vala b/vala/valasizeofexpression.vala
index d7b2c04..1064389 100644
--- a/vala/valasizeofexpression.vala
+++ b/vala/valasizeofexpression.vala
@@ -52,13 +52,15 @@ public class Vala.SizeofExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
- type_reference.accept (visitor);
-
visitor.visit_sizeof_expression (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ type_reference.accept (visitor);
+ }
+
public override bool is_pure () {
return true;
}
diff --git a/vala/valasymbolresolver.vala b/vala/valasymbolresolver.vala
index ef61c36..0afb976 100644
--- a/vala/valasymbolresolver.vala
+++ b/vala/valasymbolresolver.vala
@@ -509,14 +509,34 @@ public class Vala.SymbolResolver : CodeVisitor {
expr.accept_children (this);
}
+ public override void visit_postfix_expression (PostfixExpression expr) {
+ expr.accept_children (this);
+ }
+
public override void visit_object_creation_expression (ObjectCreationExpression expr) {
expr.accept_children (this);
}
+ public override void visit_sizeof_expression (SizeofExpression expr) {
+ expr.accept_children (this);
+ }
+
+ public override void visit_typeof_expression (TypeofExpression expr) {
+ expr.accept_children (this);
+ }
+
public override void visit_unary_expression (UnaryExpression expr) {
expr.accept_children (this);
}
+ public override void visit_cast_expression (CastExpression expr) {
+ expr.accept_children (this);
+ }
+
+ public override void visit_addressof_expression (AddressofExpression expr) {
+ expr.accept_children (this);
+ }
+
public override void visit_reference_transfer_expression (ReferenceTransferExpression expr) {
expr.accept_children (this);
}
@@ -525,6 +545,14 @@ public class Vala.SymbolResolver : CodeVisitor {
expr.accept_children (this);
}
+ public override void visit_type_check (TypeCheck expr) {
+ expr.accept_children (this);
+ }
+
+ public override void visit_conditional_expression (ConditionalExpression expr) {
+ expr.accept_children (this);
+ }
+
public override void visit_lambda_expression (LambdaExpression l) {
l.accept_children (this);
}
diff --git a/vala/valatypecheck.vala b/vala/valatypecheck.vala
index 4e002dc..9208812 100644
--- a/vala/valatypecheck.vala
+++ b/vala/valatypecheck.vala
@@ -66,15 +66,17 @@ public class Vala.TypeCheck : Expression {
}
public override void accept (CodeVisitor visitor) {
- expression.accept (visitor);
-
- type_reference.accept (visitor);
-
visitor.visit_type_check (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ expression.accept (visitor);
+
+ type_reference.accept (visitor);
+ }
+
public override bool is_pure () {
return expression.is_pure ();
}
diff --git a/vala/valatypeofexpression.vala b/vala/valatypeofexpression.vala
index 2a31ec0..d85f186 100644
--- a/vala/valatypeofexpression.vala
+++ b/vala/valatypeofexpression.vala
@@ -52,13 +52,15 @@ public class Vala.TypeofExpression : Expression {
}
public override void accept (CodeVisitor visitor) {
- type_reference.accept (visitor);
-
visitor.visit_typeof_expression (this);
visitor.visit_expression (this);
}
+ public override void accept_children (CodeVisitor visitor) {
+ type_reference.accept (visitor);
+ }
+
public override bool is_pure () {
return true;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]