[glom] Dialog_Properties: Remove the unnecessary virtual keywords.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] Dialog_Properties: Remove the unnecessary virtual keywords.
- Date: Wed, 8 Sep 2010 09:55:59 +0000 (UTC)
commit ac247bb580284d14685265439cd5e17506810cb4
Author: Murray Cumming <murrayc murrayc com>
Date: Tue Sep 7 16:15:34 2010 +0200
Dialog_Properties: Remove the unnecessary virtual keywords.
* glom/utility_widgets/dialog_properties.h: Make methods non-virtual
because nothing overrides them.
ChangeLog | 7 +++++++
glom/utility_widgets/dialog_properties.h | 14 +++++++-------
2 files changed, 14 insertions(+), 7 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index dc80590..1ffaabf 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2010-09-07 Murray Cumming <murrayc murrayc com>
+ Dialog_Properties: Remove the unnecessary virtual keywords.
+
+ * glom/utility_widgets/dialog_properties.h: Make methods non-virtual
+ because nothing overrides them.
+
+2010-09-07 Murray Cumming <murrayc murrayc com>
+
Dialog_FieldsList: Fix a crash.
* glom/mode_design/layout/layout_item_dialogs/dialog_fieldslist.cc: get_fields():
diff --git a/glom/utility_widgets/dialog_properties.h b/glom/utility_widgets/dialog_properties.h
index 3c3e67c..8d9016a 100644
--- a/glom/utility_widgets/dialog_properties.h
+++ b/glom/utility_widgets/dialog_properties.h
@@ -46,18 +46,18 @@ public:
protected:
//Signal handlers:
- virtual void on_button_save();
- virtual void on_button_cancel();
+ void on_button_save();
+ void on_button_cancel();
- virtual void on_anything_changed();
+ void on_anything_changed();
virtual void on_adddel_user_changed(const Gtk::TreeModel::iterator& /* iter */, guint /* col */);
/// Disable/enable other controls when a control is selected.
virtual void enforce_constraints();
- virtual void on_foreach_connect(Gtk::Widget& widget);
- virtual void widget_connect_changed_signal(Gtk::Widget& widget);
- virtual void set_blocked(bool val = true);
+ void on_foreach_connect(Gtk::Widget& widget);
+ void widget_connect_changed_signal(Gtk::Widget& widget);
+ void set_blocked(bool val = true);
type_signal_apply m_signal_apply;
@@ -71,7 +71,7 @@ protected:
bool m_modified;
- //typedef std::list<sigc::connection> type_listConnections; //Store the connections so that we can remove them later.
+ //typedef std::list<sigc::connection> type_listConnections; //Store the connections so that we can remove them later.
};
} //namespace Glom
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]