[nemiver] Disassemble only from addresses given by GDB



commit fecc91f2f3c119ba43ca9a50702df32abb2922fc
Author: Dodji Seketeli <dodji redhat com>
Date:   Sun Sep 5 18:00:46 2010 +0200

    Disassemble only from addresses given by GDB
    
    	* src/persp/dbgperspective/nmv-dbg-perspective.cc
    	(disassemble_around_address_and_do): Don't try to disassemble at
    	addresses that are "before" the address we were asked to
    	disassemble, after all. Starting at the wrong address can lead to
    	mis-disassembling.

 src/persp/dbgperspective/nmv-dbg-perspective.cc |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)
---
diff --git a/src/persp/dbgperspective/nmv-dbg-perspective.cc b/src/persp/dbgperspective/nmv-dbg-perspective.cc
index 4f06b81..64c9f94 100644
--- a/src/persp/dbgperspective/nmv-dbg-perspective.cc
+++ b/src/persp/dbgperspective/nmv-dbg-perspective.cc
@@ -7156,15 +7156,6 @@ DBGPerspective::disassemble_around_address_and_do
 
     addr_range.max (addr_range.max () + total_instrs_size);
 
-    // Also, try disassembling one insn *before* the starting @ of the
-    // range. Otherwise, sometimes, we miss the instruction that is at
-    // that address because GDB doesn't send it back to us in the
-    // disass. That leads to an infinite loop as our calling chain
-    // will then look for the insn having that @, won't find it, and
-    // will call us again with that @ as starting range of disass. 
-    if (addr_range.min () > instr_size)
-        addr_range.min (addr_range.min () - instr_size);
-
     debugger ()->disassemble (/*start_addr=*/addr_range.min (),
                               /*start_addr_relative_to_pc=*/false,
                               /*end_addr=*/addr_range.max (),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]