[gnome-utils] logview: Fix warnings from -Wall
- From: Benjamin Otte <otte src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-utils] logview: Fix warnings from -Wall
- Date: Wed, 1 Sep 2010 12:58:15 +0000 (UTC)
commit f36030dae090867666aee4529261fa20f11404f8
Author: Benjamin Otte <otte redhat com>
Date: Wed Sep 1 14:57:13 2010 +0200
logview: Fix warnings from -Wall
logview/logview-app.c | 1 -
logview/logview-filter-manager.c | 1 -
logview/logview-filter.c | 1 -
logview/logview-findbar.c | 4 +-
logview/logview-loglist.c | 1 -
logview/logview-main.c | 1 -
logview/logview-manager.c | 2 +-
logview/logview-prefs.c | 2 -
logview/logview-window.c | 59 +------------------------------------
9 files changed, 5 insertions(+), 67 deletions(-)
---
diff --git a/logview/logview-app.c b/logview/logview-app.c
index 245c421..a13f29d 100644
--- a/logview/logview-app.c
+++ b/logview/logview-app.c
@@ -95,7 +95,6 @@ typedef struct {
static GSList*
parse_syslog ()
{
- char *logfile = NULL;
char cbuf[BUFSIZ];
char *cline, *p;
FILE *cf;
diff --git a/logview/logview-filter-manager.c b/logview/logview-filter-manager.c
index 6d5fd30..58aa6e3 100644
--- a/logview/logview-filter-manager.c
+++ b/logview/logview-filter-manager.c
@@ -266,7 +266,6 @@ on_dialog_add_edit_reponse (GtkWidget *dialog, int response_id,
static void
run_add_edit_dialog (LogviewFilterManager *manager, LogviewFilter *filter)
{
- int response;
GError *error;
gchar *name, *regex;
const gchar *title;
diff --git a/logview/logview-filter.c b/logview/logview-filter.c
index 9c25c11..46314d0 100644
--- a/logview/logview-filter.c
+++ b/logview/logview-filter.c
@@ -122,7 +122,6 @@ static void
logview_filter_class_init (LogviewFilterClass *klass)
{
GObjectClass* object_class = G_OBJECT_CLASS (klass);
- GObjectClass* parent_class = G_OBJECT_CLASS (klass);
object_class->finalize = logview_filter_finalize;
object_class->set_property = logview_filter_set_property;
diff --git a/logview/logview-findbar.c b/logview/logview-findbar.c
index 6efbc6e..bdbda89 100644
--- a/logview/logview-findbar.c
+++ b/logview/logview-findbar.c
@@ -146,7 +146,7 @@ unbold_timeout_cb (gpointer user_data)
static void
logview_findbar_init (LogviewFindbar *findbar)
{
- GtkWidget *label, *button, *w, *box;
+ GtkWidget *label, *w, *box;
GtkToolbar *gtoolbar;
GtkToolItem *item;
LogviewFindbarPrivate *priv;
@@ -345,4 +345,4 @@ logview_findbar_set_message (LogviewFindbar *findbar,
text != NULL ? text : "");
g_object_set (findbar->priv->separator, "visible", text != NULL, NULL);
g_object_set (findbar->priv->status_item, "visible", text != NULL, NULL);
-}
\ No newline at end of file
+}
diff --git a/logview/logview-loglist.c b/logview/logview-loglist.c
index 67f09c3..5f87902 100644
--- a/logview/logview-loglist.c
+++ b/logview/logview-loglist.c
@@ -339,7 +339,6 @@ loglist_sort_func (GtkTreeModel *model,
GtkTreeIter *b,
gpointer user_data)
{
- LogviewLoglist *list = user_data;
char *name_a, *name_b;
Day *day_a, *day_b;
int retval = 0;
diff --git a/logview/logview-main.c b/logview/logview-main.c
index 233103c..ffa30a4 100644
--- a/logview/logview-main.c
+++ b/logview/logview-main.c
@@ -55,7 +55,6 @@ static GOptionContext *
create_option_context (void)
{
GOptionContext *context;
- GOptionGroup *group;
const GOptionEntry entries[] = {
{ "version", 'V', G_OPTION_FLAG_NO_ARG, G_OPTION_ARG_CALLBACK,
diff --git a/logview/logview-manager.c b/logview/logview-manager.c
index 8b85f48..c9f460e 100644
--- a/logview/logview-manager.c
+++ b/logview/logview-manager.c
@@ -27,6 +27,7 @@
#include "logview-prefs.h"
#include "logview-marshal.h"
+#include "logview-app.h"
enum {
LOG_ADDED,
@@ -278,7 +279,6 @@ void
logview_manager_set_active_log (LogviewManager *manager,
LogviewLog *log)
{
- gboolean first_read = TRUE;
LogviewLog *old_log = NULL;
g_assert (LOGVIEW_IS_MANAGER (manager));
diff --git a/logview/logview-prefs.c b/logview/logview-prefs.c
index 0022c7a..2f5308e 100644
--- a/logview/logview-prefs.c
+++ b/logview/logview-prefs.c
@@ -340,7 +340,6 @@ get_filters_foreach (gpointer key, gpointer value, gpointer user_data)
static void
logview_prefs_init (LogviewPrefs *self)
{
- gboolean stored_logs;
LogviewPrefsPrivate *priv;
priv = self->priv = GET_PRIVATE (self);
@@ -440,7 +439,6 @@ GSList *
logview_prefs_get_stored_logfiles (LogviewPrefs *prefs)
{
GSList *retval;
- GError *err = NULL;
g_assert (LOGVIEW_IS_PREFS (prefs));
diff --git a/logview/logview-window.c b/logview/logview-window.c
index 7fa61b5..3fe8d04 100644
--- a/logview/logview-window.c
+++ b/logview/logview-window.c
@@ -274,32 +274,6 @@ logview_set_window_title (LogviewWindow *logview, const char * log_name)
g_free (window_title);
}
-static void
-logview_menu_item_set_state (LogviewWindow *logview, char *path, gboolean state)
-{
- GtkAction *action;
-
- g_assert (path);
-
- action = gtk_ui_manager_get_action (logview->priv->ui_manager, path);
- gtk_action_set_sensitive (action, state);
-}
-
-static void
-logview_window_menus_set_state (LogviewWindow *logview)
-{
- LogviewLog *log;
-
- log = logview_manager_get_active_log (logview->priv->manager);
-
- logview_menu_item_set_state (logview, "/LogviewMenu/FileMenu/CloseLog", (log != NULL));
- logview_menu_item_set_state (logview, "/LogviewMenu/ViewMenu/Search", (log != NULL));
- logview_menu_item_set_state (logview, "/LogviewMenu/EditMenu/Copy", (log != NULL));
- logview_menu_item_set_state (logview, "/LogviewMenu/EditMenu/SelectAll", (log != NULL));
-
- g_object_unref (log);
-}
-
/* actions callbacks */
static void
@@ -437,8 +411,6 @@ static void
findbar_close_cb (LogviewFindbar *findbar,
gpointer user_data)
{
- LogviewWindow *logview = user_data;
-
gtk_widget_hide (GTK_WIDGET (findbar));
logview_findbar_set_message (findbar, NULL);
}
@@ -596,7 +568,7 @@ filter_buffer (LogviewWindow *logview, gint start_line)
GtkTextIter start, *end;
gchar* text;
GList* cur_filter;
- gboolean matched, invisible_set;
+ gboolean matched;
int lines, i;
buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (logview->priv->text_view));
@@ -681,7 +653,6 @@ update_filter_menu (LogviewWindow *window)
LogviewWindowPrivate *priv;
GtkUIManager* ui;
GList *actions, *l;
- gint n, i;
guint id;
GList *filters;
GtkTextBuffer *buffer;
@@ -947,29 +918,6 @@ loglist_day_cleared_cb (LogviewLoglist *loglist,
}
static void
-logview_window_select_date (LogviewWindow *logview, GDate *date)
-{
- LogviewLog *log;
- GSList *days, *l;
- Day *day;
- gboolean found = FALSE;
-
- log = logview_manager_get_active_log (logview->priv->manager);
-
- for (l = days; l; l = l->next) {
- day = l->data;
- if (g_date_compare (date, day->date) == 0) {
- found = TRUE;
- break;
- }
- }
-
- if (found) {
- real_select_day (logview, day->date, day->first_line, day->last_line);
- }
-}
-
-static void
log_monitor_changed_cb (LogviewLog *log,
gpointer user_data)
{
@@ -1276,8 +1224,6 @@ static void
message_area_response_cb (GtkInfoBar *message_area,
int response_id, gpointer user_data)
{
- LogviewWindow *window = user_data;
-
gtk_widget_hide (GTK_WIDGET (message_area));
g_signal_handlers_disconnect_by_func (message_area,
@@ -1297,11 +1243,10 @@ logview_window_finalize (GObject *object)
static void
logview_window_init (LogviewWindow *logview)
{
- gint i;
GtkActionGroup *action_group;
GtkAccelGroup *accel_group;
GError *error = NULL;
- GtkWidget *hpaned, *main_view, *scrolled, *vbox, *w;
+ GtkWidget *hpaned, *main_view, *vbox, *w;
PangoContext *context;
PangoFontDescription *fontdesc;
gchar *monospace_font_name;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]