[gstreamermm] AudioSink: Wrap boolean virtual functions.



commit 184ececaee3bbe47fbcb05327b8c4541fa41b952
Author: José Alburquerque <jaalburqu svn gnome org>
Date:   Tue Aug 31 23:35:03 2010 -0400

    	AudioSink: Wrap boolean virtual functions.
    
    	* gstreamer/src/audiosink.hg: Uncomment commented out boolean virtual
    	functions which don't appear to be a problem with the execution of the
    	examples that use plugins that inherit from this class (such as the
    	Gst::AlsaSink plugin).

 ChangeLog                  |    9 +++++++++
 gstreamer/src/audiosink.hg |   29 ++++++++++-------------------
 2 files changed, 19 insertions(+), 19 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 6f62b7d..a238e4e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2010-08-31  José Alburquerque  <jaalburqu svn gnome org>
+
+	AudioSink: Wrap boolean virtual functions.
+
+	* gstreamer/src/audiosink.hg: Uncomment commented out boolean virtual
+	functions which don't appear to be a problem with the execution of the
+	examples that use plugins that inherit from this class (such as the
+	Gst::AlsaSink plugin).
+
 2010-08-24  José Alburquerque  <jaalburqu svn gnome org>
 
 	Add initial implementation of BufferList and BufferListIterator.
diff --git a/gstreamer/src/audiosink.hg b/gstreamer/src/audiosink.hg
index 7da5291..0ba91b5 100644
--- a/gstreamer/src/audiosink.hg
+++ b/gstreamer/src/audiosink.hg
@@ -52,31 +52,22 @@ class AudioSink : public Gst::BaseAudioSink
   _CLASS_GOBJECT(AudioSink, GstAudioSink, GST_AUDIO_SINK, Gst::BaseAudioSink, GstBaseAudioSink)
 
 public:
-  //TODO: Some boolean vfuncs cause strange incorrect functionality when their
-  //callbacks return false with the last "return RType()" line.  Make sure this
-  //one doesn't cause problems and implement later.
-  ///** vfunc to open the device. No configuration needs to be done at this
-   //* point. This function is also used to check if the device is available.
-   //*/
-  //_WRAP_VFUNC(bool open(), "open")
+  /** vfunc to open the device. No configuration needs to be done at this
+   * point. This function is also used to check if the device is available.
+   */
+  _WRAP_VFUNC(bool open(), "open")
 
   /** vfunc to prepare the device to operate with the specified parameters.
    */
   virtual bool prepare_vfunc(Gst::RingBufferSpec& spec);
 
-  //TODO: Some boolean vfuncs cause strange incorrect functionality when their
-  //callbacks return false with the last "return RType()" line.  Make sure this
-  //one doesn't cause problems and implement later.
-  ///** vfunc to undo operations done in prepare.
-   //*/
-  //_WRAP_VFUNC(bool unprepare(), "unprepare")
+  /** vfunc to undo operations done in prepare.
+   */
+  _WRAP_VFUNC(bool unprepare(), "unprepare")
 
-  //TODO: Some boolean vfuncs cause strange incorrect functionality when their
-  //callbacks return false with the last "return RType()" line.  Make sure this
-  //one doesn't cause problems and implement later.
-  ///** vfunc to close the device.
-   //*/
-  //_WRAP_VFUNC(bool close(), "close")
+  /** vfunc to close the device.
+   */
+  _WRAP_VFUNC(bool close(), "close")
 
   /** vfunc to write data to the device.
    */



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]