[libxml2] Avoid a descriptor leak in catalog loading code



commit c43ac6698818d63e28f3f9691dba8a9cdbc6d469
Author: Carlo Bramini <carlo bramix libero it>
Date:   Thu Oct 14 14:27:54 2010 +0200

    Avoid a descriptor leak in catalog loading code
    
    File descriptors could be leaked in xmlLoadFileContent()

 catalog.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/catalog.c b/catalog.c
index af84b7c..f33a0aa 100644
--- a/catalog.c
+++ b/catalog.c
@@ -997,18 +997,15 @@ xmlLoadFileContent(const char *filename)
     }
 #ifdef HAVE_STAT
     len = read(fd, content, size);
+    close(fd);
 #else
     len = fread(content, 1, size, fd);
+    fclose(fd);
 #endif
     if (len < 0) {
         xmlFree(content);
         return (NULL);
     }
-#ifdef HAVE_STAT
-    close(fd);
-#else
-    fclose(fd);
-#endif
     content[len] = 0;
 
     return(content);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]