[banshee] [Metrics] Make less burdensome

[Gabriel Burt <gburt src gnome org>]

commit 4376245d7d4557e36295184292ad6f2d0b889828
Author: Gabriel Burt <gabriel burt gmail com>
Date:   Wed Oct 13 17:22:33 2010 -0500

    [Metrics] Make less burdensome
    
    Only collect data one in five runs, and only send it at most ever four
    days.  And don't try to resend data if there's a problem sending it.

 .../Banshee.Metrics/BansheeMetrics.cs              |   34 +++++++++++++-------
 1 files changed, 22 insertions(+), 12 deletions(-)
---
diff --git a/src/Core/Banshee.Services/Banshee.Metrics/BansheeMetrics.cs b/src/Core/Banshee.Services/Banshee.Metrics/BansheeMetrics.cs
index d5c4843..e1e8fb6 100644
--- a/src/Core/Banshee.Services/Banshee.Metrics/BansheeMetrics.cs
+++ b/src/Core/Banshee.Services/Banshee.Metrics/BansheeMetrics.cs
@@ -35,6 +35,7 @@ using Hyena.Data.Sqlite;
 
 using Banshee.Configuration;
 using Banshee.ServiceStack;
+using Banshee.Networking;
 using Banshee.Sources;
 using Banshee.PlaybackController;
 
@@ -50,8 +51,10 @@ namespace Banshee.Metrics
 
         public static void Start ()
         {
-            Log.Information ("Starting collection of anonymous usage data");
-            if (banshee_metrics == null) {
+            // Only enable collection 20% of the time
+            var one_in_five = new Random ().NextDouble () < 0.2;
+            if (one_in_five && banshee_metrics == null) {
+                Log.Information ("Starting collection of anonymous usage data");
                 try {
                     banshee_metrics = new BansheeMetrics ();
                 } catch (Exception e) {
@@ -63,8 +66,8 @@ namespace Banshee.Metrics
 
         public static void Stop ()
         {
-            Log.Information ("Stopping collection of anonymous usage data");
             if (banshee_metrics != null) {
+                Log.Information ("Stopping collection of anonymous usage data");
                 banshee_metrics.Dispose ();
                 banshee_metrics = null;
             }
@@ -113,28 +116,35 @@ namespace Banshee.Metrics
                     return false;
                 }
 
-                metrics.AddDefaults ();
-                AddMetrics ();
-
                 ThreadAssist.SpawnFromMain (delegate {
+                    metrics.AddDefaults ();
+                    AddMetrics ();
+
                     if (ApplicationContext.CommandLine.Contains ("debug-metrics")) {
                         Log.InformationFormat ("Anonymous usage data collected:\n{0}", metrics.ToJsonString ());
                         System.IO.File.WriteAllText ("usage-data.json", metrics.ToJsonString ());
                     }
 
+                    if (!ServiceManager.Get<Network> ().Connected) {
+                        return;
+                    }
+
                     // Don't post to server more than every 48 hours
                     var last_post_time = DatabaseConfigurationClient.Client.Get<DateTime> (last_post_key, DateTime.MinValue);
-                    var last_post_rel = (DateTime.Now - last_post_time).TotalHours;
-                    if (last_post_rel < 0 || last_post_rel > 48.0) {
+                    var last_post_rel = (DateTime.Now - last_post_time).TotalDays;
+                    if (last_post_rel < 0 || last_post_rel > 4.0) {
                         var poster = new HttpPoster ("http://metrics.banshee.fm/submit/";, metrics);
                         bool posted = poster.Post ();
                         Log.InformationFormat ("Posted usage data? {0}", posted);
-                        if (posted) {
-                            metrics.Store.Clear ();
-                            DatabaseConfigurationClient.Client.Set<DateTime> (last_post_key, DateTime.Now);
-                        }
+
+                        // Clear the old metrics, even if we failed to post them; it might be a server-side
+                        // problem w/ the data we want to send (eg too big, out of space) and we don't want
+                        // to keep retrying to send the same data.
+                        metrics.Store.Clear ();
+                        DatabaseConfigurationClient.Client.Set<DateTime> (last_post_key, DateTime.Now);
                     }
                 });
+
                 return false;
             });
         }