[gtk+] Use and print note for key only if there are credentials
- From: Christian Dywan <cdywan src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gtk+] Use and print note for key only if there are credentials
- Date: Fri, 8 Oct 2010 14:03:46 +0000 (UTC)
commit e9a7a2104be326ca96b49b5a583e1ff89f69f9d6
Author: Christian Dywan <christian twotoasts de>
Date: Fri Oct 8 16:01:07 2010 +0200
Use and print note for key only if there are credentials
Otherwise key might be printed uninitialized.
modules/printbackends/cups/gtkprintbackendcups.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
---
diff --git a/modules/printbackends/cups/gtkprintbackendcups.c b/modules/printbackends/cups/gtkprintbackendcups.c
index 62deac4..7b0b0e2 100644
--- a/modules/printbackends/cups/gtkprintbackendcups.c
+++ b/modules/printbackends/cups/gtkprintbackendcups.c
@@ -707,7 +707,6 @@ gtk_print_backend_cups_set_password (GtkPrintBackend *backend,
GtkPrintBackendCups *cups_backend = GTK_PRINT_BACKEND_CUPS (backend);
GList *l;
char dispatch_hostname[HTTP_MAX_URI];
- gchar *key;
gchar *username = NULL;
gchar *hostname = NULL;
gchar *password = NULL;
@@ -729,15 +728,15 @@ gtk_print_backend_cups_set_password (GtkPrintBackend *backend,
if (hostname != NULL && username != NULL && password != NULL)
{
- key = g_strconcat (username, "@", hostname, NULL);
+ gchar *key = g_strconcat (username, "@", hostname, NULL);
g_hash_table_insert (cups_backend->auth, key, g_strdup (password));
+ GTK_NOTE (PRINTING,
+ g_print ("CUPS backend: storing password for %s\n", key));
}
g_free (cups_backend->username);
cups_backend->username = g_strdup (username);
- GTK_NOTE (PRINTING,
- g_print ("CUPS backend: storing password for %s\n", key));
for (l = cups_backend->requests; l; l = l->next)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]