[nemiver/remote-cmdline: 1/2] Cleanup remote target port use.



commit 2eb1f5e3129d53ba7ac0c753054ab8920d719614
Author: Dodji Seketeli <dodji seketeli org>
Date:   Sun Oct 3 16:51:50 2010 +0200

    Cleanup remote target port use.
    
    	* src/dbgengine/nmv-i-debugger.h (attach_to_remote_target): Remote
    	target port should be unsigned.
    	* src/dbgengine/nmv-gdb-engine.h
    	(IDebugger::attach_to_remote_target): Likewise.
    	* src/dbgengine/nmv-gdb-engine.cc
    	(GDBEngine::attach_to_remote_target): Likewise.
    	* src/persp/dbgperspective/nmv-remote-target-dialog.cc
    	src/persp/dbgperspective/nmv-remote-target-dialog.h
    	(RemoteTargetDialog::get_server_port):
    	(RemoteTargetDialog::get_server_port): Likewise.

 src/dbgengine/nmv-gdb-engine.cc                    |    3 ++-
 src/dbgengine/nmv-gdb-engine.h                     |    2 +-
 src/dbgengine/nmv-i-debugger.h                     |    2 +-
 .../dbgperspective/nmv-remote-target-dialog.cc     |    4 ++--
 .../dbgperspective/nmv-remote-target-dialog.h      |    4 ++--
 5 files changed, 8 insertions(+), 7 deletions(-)
---
diff --git a/src/dbgengine/nmv-gdb-engine.cc b/src/dbgengine/nmv-gdb-engine.cc
index dfd4b7b..4356f6e 100644
--- a/src/dbgengine/nmv-gdb-engine.cc
+++ b/src/dbgengine/nmv-gdb-engine.cc
@@ -2711,7 +2711,8 @@ GDBEngine::attach_to_target (unsigned int a_pid,
 }
 
 bool
-GDBEngine::attach_to_remote_target (const UString &a_host, int a_port)
+GDBEngine::attach_to_remote_target (const UString &a_host,
+				    unsigned a_port)
 {
     queue_command (Command ("-target-select remote " + a_host +
                             ":" + UString::from_int (a_port)));
diff --git a/src/dbgengine/nmv-gdb-engine.h b/src/dbgengine/nmv-gdb-engine.h
index cd36ef1..24ef329 100644
--- a/src/dbgengine/nmv-gdb-engine.h
+++ b/src/dbgengine/nmv-gdb-engine.h
@@ -260,7 +260,7 @@ public:
     bool attach_to_target (unsigned int a_pid,
                            const UString &a_tty_path);
 
-    bool attach_to_remote_target (const UString &a_host, int a_port);
+    bool attach_to_remote_target (const UString &a_host, unsigned a_port);
 
     bool attach_to_remote_target (const UString &a_serial_line);
 
diff --git a/src/dbgengine/nmv-i-debugger.h b/src/dbgengine/nmv-i-debugger.h
index 54b92f5..9fca203 100644
--- a/src/dbgengine/nmv-i-debugger.h
+++ b/src/dbgengine/nmv-i-debugger.h
@@ -1034,7 +1034,7 @@ public:
                                    const UString &a_tty_path="") = 0;
 
     virtual bool attach_to_remote_target (const UString &a_host,
-                                          int a_port) = 0;
+                                          unsigned a_port) = 0;
 
     virtual bool attach_to_remote_target (const UString &a_serial_line) = 0;
 
diff --git a/src/persp/dbgperspective/nmv-remote-target-dialog.cc b/src/persp/dbgperspective/nmv-remote-target-dialog.cc
index 0ae7ab6..4a474f1 100644
--- a/src/persp/dbgperspective/nmv-remote-target-dialog.cc
+++ b/src/persp/dbgperspective/nmv-remote-target-dialog.cc
@@ -339,7 +339,7 @@ RemoteTargetDialog::set_server_address (const UString &a_address)
     m_priv->set_server_address (a_address);
 }
 
-int
+unsigned
 RemoteTargetDialog::get_server_port () const
 {
     THROW_IF_FAIL (m_priv);
@@ -347,7 +347,7 @@ RemoteTargetDialog::get_server_port () const
 }
 
 void
-RemoteTargetDialog::set_server_port (int a_port)
+RemoteTargetDialog::set_server_port (unsigned a_port)
 {
     THROW_IF_FAIL (m_priv);
     m_priv->set_server_port (a_port);
diff --git a/src/persp/dbgperspective/nmv-remote-target-dialog.h b/src/persp/dbgperspective/nmv-remote-target-dialog.h
index 1548382..20864f3 100644
--- a/src/persp/dbgperspective/nmv-remote-target-dialog.h
+++ b/src/persp/dbgperspective/nmv-remote-target-dialog.h
@@ -54,8 +54,8 @@ public:
     const UString& get_server_address () const;
     void set_server_address (const UString &a_address);
 
-    int get_server_port () const;
-    void set_server_port (int a_port);
+    unsigned get_server_port () const;
+    void set_server_port (unsigned a_port);
 
     const UString& get_serial_port_name () const;
     void set_serial_port_name (const UString &a_serial);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]