[libdmapsharing] Add comment to code describing previous commit Signed-off-by: W. Michael Petullo <mike flyn org>



commit fb9f9ab7eda6d340aa61b13a3c76a9ba93668d65
Author: W. Michael Petullo <mike flyn org>
Date:   Thu Nov 25 23:33:23 2010 -0600

    Add comment to code describing previous commit
    Signed-off-by: W. Michael Petullo <mike flyn org>

 libdmapsharing/dpap-share.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
---
diff --git a/libdmapsharing/dpap-share.c b/libdmapsharing/dpap-share.c
index d588cfa..4fc3135 100644
--- a/libdmapsharing/dpap-share.c
+++ b/libdmapsharing/dpap-share.c
@@ -330,6 +330,10 @@ file_to_mmap (const char *location)
         GError *error = NULL;
 
         file = g_file_new_for_uri (location);
+	/* NOTE: this is broken if original filename contains "%20" etc. This
+	 * is because g_file_get_path() will translate this to " ", etc. But
+	 * the filename really may have used "%20" (not " ").
+	 */
         path = g_file_get_path (file);
         if (path == NULL) {
                 g_warning ("Couldn't mmap %s: couldn't get path", path);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]