[gtk+] Changing GtkBox:fill child property default back to TRUE.



commit eb5a5004959227d22b2f98a157beda8600df00d3
Author: Tristan Van Berkom <tristan van berkom gmail com>
Date:   Thu Nov 25 14:37:02 2010 +0900

    Changing GtkBox:fill child property default back to TRUE.
    
    Since Havoc's patches introducing the GtkWidget halign/valign
    properties, fill should always be TRUE. If the widget should
    not fill its allocated space then it should set the halign or
    valign properties for that purpose.
    
    This also consequently fixes bug 634592.

 gtk/gtkbox.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)
---
diff --git a/gtk/gtkbox.c b/gtk/gtkbox.c
index 9786b3b..e3c4b42 100644
--- a/gtk/gtkbox.c
+++ b/gtk/gtkbox.c
@@ -274,17 +274,13 @@ gtk_box_class_init (GtkBoxClass *class)
    * GtkBox:fill:
    *
    * Whether the child should receive extra space when the parent grows.
-   *
-   * Note that the default value for this property is %FALSE for GtkBox,
-   * but #GtkHBox, #GtkVBox and other subclasses use the old default
-   * of %TRUE.
    */
   gtk_container_class_install_child_property (container_class,
 					      CHILD_PROP_FILL,
 					      g_param_spec_boolean ("fill",
 								    P_("Fill"),
 								    P_("Whether extra space given to the child should be allocated to the child or used as padding"),
-								    FALSE,
+								    TRUE,
 								    GTK_PARAM_READWRITE));
 
   gtk_container_class_install_child_property (container_class,
@@ -1648,7 +1644,7 @@ gtk_box_add (GtkContainer *container,
 
   gtk_box_pack_start (GTK_BOX (container), widget,
                       priv->default_expand,
-                      priv->default_expand,
+                      TRUE,
                       0);
 }
 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]