[gnome-keyring/trust-store] [gkm] PKCS#11 objects may be deletable even when not modifiable.



commit c71f37f906c63291be247ad4a2b7705df83702c0
Author: Stef Walter <stefw collabora co uk>
Date:   Wed Nov 24 23:01:51 2010 +0000

    [gkm] PKCS#11 objects may be deletable even when not modifiable.
    
     * PKCS#11 spec has no way to signify whether an object is
       deletable or not.

 pkcs11/gkm/gkm-session.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/pkcs11/gkm/gkm-session.c b/pkcs11/gkm/gkm-session.c
index 51ffed3..4a43c8d 100644
--- a/pkcs11/gkm/gkm-session.c
+++ b/pkcs11/gkm/gkm-session.c
@@ -241,7 +241,6 @@ lookup_object_from_handle (GkmSession *self, CK_OBJECT_HANDLE handle,
 	GkmObject *object;
 	gboolean is_private;
 	gboolean is_token;
-	gboolean is_modifiable;
 
 	g_return_val_if_fail (result, CKR_GENERAL_ERROR);
 	g_return_val_if_fail (GKM_IS_SESSION (self), CKR_GENERAL_ERROR);
@@ -289,10 +288,6 @@ lookup_object_from_handle (GkmSession *self, CK_OBJECT_HANDLE handle,
 			if (self->pv->read_only)
 				return CKR_SESSION_READ_ONLY;
 		}
-		if (!gkm_object_get_attribute_boolean (object, self, CKA_MODIFIABLE, &is_modifiable))
-			is_modifiable = FALSE;
-		if (!is_modifiable) /* What's a better return code in this case? */
-			return CKR_ATTRIBUTE_READ_ONLY;
 	}
 
 	*result = object;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]