[banshee] [libbanshee] Improve comment for playbin2 workaround
- From: Gabriel Burt <gburt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [banshee] [libbanshee] Improve comment for playbin2 workaround
- Date: Wed, 17 Nov 2010 20:38:24 +0000 (UTC)
commit 08d28ecbf82ee0605ebbe229439127b59d66998a
Author: David Nielsen <gnomeuser gmail com>
Date: Wed Nov 10 23:50:39 2010 -0200
[libbanshee] Improve comment for playbin2 workaround
Specifically, add what bug the about-to-finish signal workaround is
there because of, and what version the fix is now in.
Signed-off-by: Gabriel Burt <gabriel burt gmail com>
libbanshee/banshee-player-pipeline.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
---
diff --git a/libbanshee/banshee-player-pipeline.c b/libbanshee/banshee-player-pipeline.c
index ce16a48..abf0bfb 100644
--- a/libbanshee/banshee-player-pipeline.c
+++ b/libbanshee/banshee-player-pipeline.c
@@ -302,8 +302,9 @@ _bp_pipeline_construct (BansheePlayer *player)
player->supports_stream_volume ? "YES" : "NO");
#ifdef ENABLE_GAPLESS
- // Connect a proxy about-to-finish callback that will generate a next-track-starting callback.
+ // FIXME: Connect a proxy about-to-finish callback that will generate a next-track-starting callback.
// This can be removed once playbin2 generates its own next-track signal.
+ // bgo#584987 - this is included in >= 0.10.26
g_signal_connect (player->playbin, "about-to-finish", G_CALLBACK (bp_about_to_finish_callback), player);
#endif //ENABLE_GAPLESS
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]