[glom] Import tests: Disable more tests that do not seem useful.



commit 96dff9506cfab278bb0a484ab30ea79cbf7ebdb4
Author: Murray Cumming <murrayc murrayc com>
Date:   Mon Nov 15 00:55:12 2010 +0100

    Import tests: Disable more tests that do not seem useful.
    
    	* tests/import/test_parsing.cc: Comment out the non-comma separators test and
    	the ignoring-space-between-quoted-text test, because they don't seem to
    	correspond to any specification.

 ChangeLog                    |    8 ++++++++
 tests/import/test_parsing.cc |    9 ++++++++-
 2 files changed, 16 insertions(+), 1 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 4f22993..74d5f30 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,13 @@
 2010-11-15  Murray Cumming  <murrayc murrayc com>
 
+	Import tests: Disable more tests that do not seem useful.
+
+	* tests/import/test_parsing.cc: Comment out the non-comma separators test and 
+	the ignoring-space-between-quoted-text test, because they don't seem to 
+	correspond to any specification.
+
+2010-11-15  Murray Cumming  <murrayc murrayc com>
+
 	Import tests: Disable tests that check for incorrect or useless behaviour.
 
 	* tests/import/test_parsing.cc: Comment out the test to ensure that we 
diff --git a/tests/import/test_parsing.cc b/tests/import/test_parsing.cc
index 60c9708..821c537 100644
--- a/tests/import/test_parsing.cc
+++ b/tests/import/test_parsing.cc
@@ -138,6 +138,7 @@ int main(int argc, char* argv[])
 
   // test_skip_spaces_around_separators
   // TODO: This seems wise, but where is it specified? murrayc.
+  /*
   {
     const char* raw = "\"spaces\" , \"around\", \"separators\"\n";
     const bool finished_parsing = ImportTests::run_parser_from_buffer(&connect_signals, raw);
@@ -148,12 +149,16 @@ int main(int argc, char* argv[])
     get_tokens_instance().clear();
 
     if(!ImportTests::check("test_skip_spaces_around_separators", passed, report))
+    {
       result = false;
+    }
 
   }
+  */
 
   // test_fail_on_non_comma_separators
-  // TODO: Where is this behaviour (ignoring text between quoted text) specified?
+  // TODO: Where is this behaviour (ignoring text between quoted text) specified? murray
+  /*
   {
     const char* raw = "\"cannot\"\t\"tokenize\"\t\"this\"\n";
     const bool finished_parsing = ImportTests::run_parser_from_buffer(&connect_signals, raw);
@@ -161,11 +166,13 @@ int main(int argc, char* argv[])
     const bool passed = (finished_parsing &&
                          check_tokens("^cannottokenizethis$") && //Matches this text with nothing else at the start or end.
                          1 == get_tokens_instance().size());
+              print_tokens();
     get_tokens_instance().clear();
 
     if(!ImportTests::check("test_fail_on_non_comma_separators", passed, report))
       result = false;
   }
+  */
 
   // test_parse_newline_inside_quotes
   {



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]