[folks] Remove casting convenience functions in Individual



commit def47dffa31a95ec6bd333f43c69822416098283
Author: Philip Withnall <philip withnall collabora co uk>
Date:   Fri Sep 10 15:25:31 2010 +0100

    Remove casting convenience functions in Individual
    
    They're not needed for Vala, and weren't particularly well thought
    out (or complete) in C.

 NEWS                  |    1 +
 folks/individual.vala |   79 -------------------------------------------------
 2 files changed, 1 insertions(+), 79 deletions(-)
---
diff --git a/NEWS b/NEWS
index 3bb7a6d..79ab8bf 100644
--- a/NEWS
+++ b/NEWS
@@ -13,6 +13,7 @@ API changes:
 * Add BackendStore.enable_backend().
 * Add BackendStore.disable_backend().
 * Add BackendStore.unprepare().
+* Remove casting convenience methods on Individual (casting isn't hard)
 
 Bugs fixed:
 * Bug 629081 â?? Add API to allow specific backends to be disabled
diff --git a/folks/individual.vala b/folks/individual.vala
index d635ac9..21da564 100644
--- a/folks/individual.vala
+++ b/folks/individual.vala
@@ -720,85 +720,6 @@ public class Folks.Individual : Object,
       this.notify_property ("im-addresses");
     }
 
-  /*
-   * GLib/C convenience functions (for built-in casting, etc.)
-   */
-
-  /**
-   * Get the Individual's alias.
-   *
-   * The alias is a user-chosen name for the Individual; how the user wants that
-   * Individual to be represented in UIs.
-   *
-   * @return the Individual's alias
-   */
-  public unowned string get_alias ()
-    {
-      return this.alias;
-    }
-
-  /**
-   * Get a mapping of group ID to whether the Individual is a member.
-   *
-   * Freeform group IDs are mapped to a boolean which is `true` if the
-   * Individual is a member of the group, and `false` otherwise.
-   *
-   * @return a mapping of group ID to membership status
-   */
-  public HashTable<string, bool> get_groups ()
-    {
-      Groupable g = this;
-      return g.groups;
-    }
-
-  /**
-   * Get the Individual's current presence message.
-   *
-   * The presence message returned is from the same { link Persona} which
-   * provided the presence type returned by
-   * { link Individual.get_presence_type}.
-   *
-   * If none of the { link Persona}s in the Individual have a presence message
-   * set, an empty string is returned.
-   *
-   * @return the Individual's presence message
-   */
-  public unowned string get_presence_message ()
-    {
-      return this.presence_message;
-    }
-
-  /**
-   * Get the Individual's current presence type.
-   *
-   * The presence type returned is from the same { link Persona} which provided
-   * the presence message returned by { link Individual.get_presence_message}.
-   *
-   * If none of the { link Persona}s in the Individual have a presence type set,
-   * { link PresenceType.UNSET} is returned.
-   *
-   * @return the Individual's presence type
-   */
-  public Folks.PresenceType get_presence_type ()
-    {
-      return this.presence_type;
-    }
-
-  /**
-   * Whether the Individual is online.
-   *
-   * This will be `true` if any of the Individual's { link Persona}s have a
-   * presence type higher than { link PresenceType.OFFLINE}, as determined by
-   * { link Presence.typecmp}.
-   *
-   * @return `true` if the Individual is online, `false` otherwise
-   */
-  public bool is_online ()
-    {
-      Presence p = this;
-      return p.is_online ();
-    }
-
   private void connect_to_persona (Persona persona)
     {
       persona.notify["alias"].connect (this.notify_alias_cb);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]