[glom] CSV Import: Actually preview and import the field values.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] CSV Import: Actually preview and import the field values.
- Date: Fri, 12 Nov 2010 10:34:11 +0000 (UTC)
commit f1e987d93f25086048db23812c9d55991e23dd33
Author: Murray Cumming <murrayc murrayc com>
Date: Fri Nov 12 11:32:44 2010 +0100
CSV Import: Actually preview and import the field values.
* glom/import_csv/csv_parser.cc: advance_field(): Remove an excess continue,
so that we actually add the character to the field's text. This error
was probably introduced while removing the non-exceptions ifdefs.
We really must fix those import unit tests so that something like this does
not happen again.
ChangeLog | 11 +++++++++++
glom/import_csv/csv_parser.cc | 2 --
2 files changed, 11 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 4382f8b..0ccac37 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2010-11-12 Murray Cumming <murrayc murrayc com>
+
+ CSV Import: Actually preview and import the field values.
+
+ * glom/import_csv/csv_parser.cc: advance_field(): Remove an excess continue,
+ so that we actually add the character to the field's text. This error
+ was probably introduced while removing the non-exceptions ifdefs.
+
+ We really must fix those import unit tests so that something like this does
+ not happen again.
+
2010-11-11 Murray Cumming <murrayc murrayc com>
List view: Make the retry option actually work afer entering invalid data.
diff --git a/glom/import_csv/csv_parser.cc b/glom/import_csv/csv_parser.cc
index 40e8c51..eebce9d 100644
--- a/glom/import_csv/csv_parser.cc
+++ b/glom/import_csv/csv_parser.cc
@@ -247,8 +247,6 @@ Glib::ustring::const_iterator CsvParser::advance_field(const Glib::ustring::cons
{
break;
}
-
- continue;
}
field += c; // Just so that we don't need to iterate through the field again, since there is no Glib::ustring::substr(iter, iter)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]