[hyena/sqlite] [Hyena.Data.Sqlite] Remove obsolete disposed test
- From: Gabriel Burt <gburt src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [hyena/sqlite] [Hyena.Data.Sqlite] Remove obsolete disposed test
- Date: Thu, 11 Nov 2010 02:57:28 +0000 (UTC)
commit 9d993996e50e44037736d251250857b031ccbac3
Author: Gabriel Burt <gabriel burt gmail com>
Date: Wed Nov 10 20:48:43 2010 -0600
[Hyena.Data.Sqlite] Remove obsolete disposed test
.../Hyena.Data.Sqlite/HyenaSqliteCommand.cs | 1 -
.../Hyena.Data.Sqlite/HyenaSqliteConnection.cs | 19 -------------------
.../Hyena.Data.Sqlite/Tests/SqliteCommandTests.cs | 17 -----------------
3 files changed, 0 insertions(+), 37 deletions(-)
---
diff --git a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteCommand.cs b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteCommand.cs
index a096834..c985325 100644
--- a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteCommand.cs
+++ b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteCommand.cs
@@ -94,7 +94,6 @@ namespace Hyena.Data.Sqlite
bool dispose_command = ReaderDisposes;
var sql_command = connection.CreateStatement (CurrentSqlText);
sql_command.ReaderDisposes = ReaderDisposes;
- hconnection.OnExecuting (sql_command);
try {
ticks = System.Environment.TickCount;
diff --git a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteConnection.cs b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteConnection.cs
index f366baa..dc03bd3 100644
--- a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteConnection.cs
+++ b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/HyenaSqliteConnection.cs
@@ -68,15 +68,6 @@ namespace Hyena.Data.Sqlite
}
}
- internal class ExecutingEventArgs : EventArgs
- {
- public readonly Statement Command;
- public ExecutingEventArgs (Statement command)
- {
- Command = command;
- }
- }
-
public enum HyenaCommandType {
Reader,
Scalar,
@@ -116,8 +107,6 @@ namespace Hyena.Data.Sqlite
public string ServerVersion { get { return Query<string> ("SELECT sqlite_version ()"); } }
- internal event EventHandler<ExecutingEventArgs> Executing;
-
public HyenaSqliteConnection(string dbpath)
{
this.dbpath = dbpath;
@@ -458,14 +447,6 @@ namespace Hyena.Data.Sqlite
connection.Dispose ();
}
- internal void OnExecuting (Statement command)
- {
- EventHandler<ExecutingEventArgs> handler = Executing;
- if (handler != null) {
- handler (this, new ExecutingEventArgs (command));
- }
- }
-
#endregion
public void Dispose()
diff --git a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/Tests/SqliteCommandTests.cs b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/Tests/SqliteCommandTests.cs
index e212010..7885902 100644
--- a/Hyena.Data.Sqlite/Hyena.Data.Sqlite/Tests/SqliteCommandTests.cs
+++ b/Hyena.Data.Sqlite/Hyena.Data.Sqlite/Tests/SqliteCommandTests.cs
@@ -95,23 +95,6 @@ namespace Hyena.Data.Sqlite.Tests
GetGeneratedSql (cmd3, new int [] {1, 2, 4}, new string [] {"foo", "baz"}));
}
- [Test]
- public void ExecuteMustDisposeSqliteCommand ()
- {
- using(var connection = new HyenaSqliteConnection (":memory:")) {
- bool disposed = false;
- connection.Executing += delegate (object sender, ExecutingEventArgs args) {
- args.Command.Disposed += delegate {
- disposed = true;
- };
- };
-
- connection.Query<int> ("SELECT 42");
-
- Assert.IsTrue (disposed);
- }
- }
-
static PropertyInfo tf = typeof(HyenaSqliteCommand).GetProperty ("CurrentSqlText", BindingFlags.Instance | BindingFlags.NonPublic);
private static string GetGeneratedSql (HyenaSqliteCommand cmd, params object [] p)
{
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]