[perl-Glib-Object-Introspection] Fix callback handling
- From: Torsten Schönfeld <tsch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [perl-Glib-Object-Introspection] Fix callback handling
- Date: Tue, 9 Nov 2010 23:05:40 +0000 (UTC)
commit 84e0fcef81789a4dd90a552582b45d7113b5cc7f
Author: Torsten Schönfeld <kaffeetisch gmx de>
Date: Tue Nov 9 21:28:38 2010 +0100
Fix callback handling
The bookkeeping of the current position in the argument list started
being off by one recently. Adjust.
GObjectIntrospection.xs | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/GObjectIntrospection.xs b/GObjectIntrospection.xs
index 1186669..e708b8e 100644
--- a/GObjectIntrospection.xs
+++ b/GObjectIntrospection.xs
@@ -1757,11 +1757,12 @@ PPCODE:
guint perl_stack_pos = i + method_offset + stack_offset
+ invocation_info.dynamic_stack_offset;
- /* FIXME: Is it right to just add method_offset here? I'm
- * confused about the relation of the numbers in
- * g_callable_info_get_arg and g_arg_info_get_closure and
- * g_arg_info_get_destroy. */
- invocation_info.current_pos = i + method_offset;
+ /* FIXME: Is this right? I'm confused about the relation of
+ * the numbers in g_callable_info_get_arg and
+ * g_arg_info_get_closure and g_arg_info_get_destroy. We used
+ * to add method_offset, but that stopped being correct at some
+ * point. */
+ invocation_info.current_pos = i; /* + method_offset; */
dwarn (" arg tag: %d (%s)\n",
g_type_info_get_tag (arg_type),
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]