[sapwood] small fixes for warnings



commit 62b9891a81e1e2cb8648869d14e0cf2f4ddb7505
Author: Sven Herzberg <sven herzberg lanedo com>
Date:   Tue Nov 2 17:11:07 2010 +0100

    small fixes for warnings
    
    * autogen.sh: abort on the first error
    * server/sapwood-server.c: read the result of the write() call (to satisfy
      two compiler warnings about unused important results)

 autogen.sh              |    1 +
 server/sapwood-server.c |    8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)
---
diff --git a/autogen.sh b/autogen.sh
index accf354..ba8fa69 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,5 +1,6 @@
 #!/bin/sh
 
+set -e
 set -x
 libtoolize --automake
 aclocal || aclocal-1.8
diff --git a/server/sapwood-server.c b/server/sapwood-server.c
index 815b93c..00ed3dd 100644
--- a/server/sapwood-server.c
+++ b/server/sapwood-server.c
@@ -370,8 +370,10 @@ process_buffer (int fd, char *buf, ssize_t buflen, gpointer user_data)
       if (base->length < sizeof (PixbufOpenRequest) + 1)
 	{
 	  char buf[1] = { '-' };
+          int written;
 
-	  write (fd, buf, 1);
+	  written = write (fd, buf, G_N_ELEMENTS (buf));
+          g_warn_if_fail (written == G_N_ELEMENTS (buf));
 
 	  g_warning ("short request, only %d bytes, expected at least %d",
 		     base->length, sizeof (PixbufOpenRequest) + 1);
@@ -405,8 +407,10 @@ process_buffer (int fd, char *buf, ssize_t buflen, gpointer user_data)
       else
 	{
 	  char buf[1] = { '-' };
+          int written;
 
-	  write (fd, buf, 1);
+	  written = write (fd, buf, G_N_ELEMENTS (buf));
+          g_warn_if_fail (written == G_N_ELEMENTS (buf));
 
 	  g_cache_remove (pixmap_cache, rep);
 	}



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]