[glom] UsesRelationship: Use SqlBuilder::select_add_target() with the join.
- From: Murray Cumming <murrayc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glom] UsesRelationship: Use SqlBuilder::select_add_target() with the join.
- Date: Fri, 21 May 2010 14:36:48 +0000 (UTC)
commit 0d36a57493a3070177a3639dd577f77139443802
Author: Murray Cumming <murrayc murrayc com>
Date: Fri May 21 16:36:38 2010 +0200
UsesRelationship: Use SqlBuilder::select_add_target() with the join.
* glom/libglom/data_structure/layout/usesrelationship.cc:
add_sql_join_alias_definition(): Use select_add_target() instead of
add_id() with the join's first target, to avoid the warning about an
unknown ID, though we now get a warning about unimplmented code in libgda,
which I emailed the gnome-db mailing list about.
ChangeLog | 10 ++++++++++
.../data_structure/layout/usesrelationship.cc | 4 ++--
2 files changed, 12 insertions(+), 2 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index 82c95a5..eaff01a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
2010-05-21 Murray Cumming <murrayc murrayc com>
+ UsesRelationship: Use SqlBuilder::select_add_target() with the join.
+
+ * glom/libglom/data_structure/layout/usesrelationship.cc:
+ add_sql_join_alias_definition(): Use select_add_target() instead of
+ add_id() with the join's first target, to avoid the warning about an
+ unknown ID, though we now get a warning about unimplmented code in libgda,
+ which I emailed the gnome-db mailing list about.
+
+2010-05-21 Murray Cumming <murrayc murrayc com>
+
Really replace the last non-users string-based SQL query.
* glom/libglom/db_utils.cc:
diff --git a/glom/libglom/data_structure/layout/usesrelationship.cc b/glom/libglom/data_structure/layout/usesrelationship.cc
index 36e8aed..71cfd88 100644
--- a/glom/libglom/data_structure/layout/usesrelationship.cc
+++ b/glom/libglom/data_structure/layout/usesrelationship.cc
@@ -228,7 +228,7 @@ void UsesRelationship::add_sql_join_alias_definition(const Glib::RefPtr<Gnome::G
if(!get_has_related_relationship_name())
{
builder->select_join_targets(
- builder->add_id(m_relationship->get_from_table()), //TODO: Must we use the ID from select_add_target_id()?
+ builder->select_add_target(m_relationship->get_from_table()),
to_target_id,
Gnome::Gda::SQL_SELECT_JOIN_LEFT,
builder->add_cond(
@@ -242,7 +242,7 @@ void UsesRelationship::add_sql_join_alias_definition(const Glib::RefPtr<Gnome::G
parent_relationship.set_relationship(m_relationship);
builder->select_join_targets(
- builder->add_id(m_relationship->get_from_table()), //TODO: Must we use the ID from select_add_target_id()?
+ builder->select_add_target(m_relationship->get_from_table()), //TODO: Must we use the ID from select_add_target_id()?
to_target_id,
Gnome::Gda::SQL_SELECT_JOIN_LEFT,
builder->add_cond(
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]