[f-spot] No need to check result as if result is false, an exception will be thrown before.



commit 7fb498043ffb2bbe062850beefdb5395a27c096c
Author: Paul Wellner Bou <paul purecodes org>
Date:   Wed May 19 12:12:50 2010 +0200

    No need to check result as if result is false, an exception will be thrown before.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=619014

 extensions/Exporters/FolderExport/FolderExport.cs |   16 ++++++----------
 1 files changed, 6 insertions(+), 10 deletions(-)
---
diff --git a/extensions/Exporters/FolderExport/FolderExport.cs b/extensions/Exporters/FolderExport/FolderExport.cs
index 0cf6832..83bd973 100644
--- a/extensions/Exporters/FolderExport/FolderExport.cs
+++ b/extensions/Exporters/FolderExport/FolderExport.cs
@@ -250,16 +250,12 @@ namespace FSpotFolderExport {
 					System.Console.WriteLine ("Transferring {0} to {1}", source.ToString (), target.ToString ());
 					result = source.CopyRecursive (target, GLib.FileCopyFlags.Overwrite, new GLib.Cancellable (), Progress);
 				}
-
-				if (result == true) {
-					progress_dialog.Message = Catalog.GetString ("Done Sending Photos");
-					progress_dialog.Fraction = 1.0;
-					progress_dialog.ProgressText = Catalog.GetString ("Transfer Complete");
-					progress_dialog.ButtonLabel = Gtk.Stock.Ok;
-				} else {
-					progress_dialog.ProgressText = result.ToString ();
-					progress_dialog.Message = Catalog.GetString ("Error While Transferring");
-				}
+				
+				// No need to check result here as if result is not true, an Exception will be thrown before
+				progress_dialog.Message = Catalog.GetString ("Done Sending Photos");
+				progress_dialog.Fraction = 1.0;
+				progress_dialog.ProgressText = Catalog.GetString ("Transfer Complete");
+				progress_dialog.ButtonLabel = Gtk.Stock.Ok;
 
 				if (open) {
 					Log.Debug (String.Format (Catalog.GetString ("Open URI {0}"), target.Uri.ToString ()));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]