[goffice] Leaks.



commit 20ee29850efbfca34d29c87e3945d5d7aac01515
Author: Morten Welinder <terra gnome org>
Date:   Thu May 13 22:38:35 2010 -0400

    Leaks.

 ChangeLog                                |    4 ++++
 NEWS                                     |   21 +++++++++++----------
 goffice/component/go-component-factory.c |    4 ++--
 3 files changed, 17 insertions(+), 12 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d7a7817..8687b68 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2010-05-13  Morten Welinder  <terra gnome org>
 
+	* goffice/component/go-component-factory.c (go_component_type_service_read_xml):
+	Plug leak.
+	(go_component_type_service_deactivate): Plug leak.
+
 	* goffice/math/go-regression.c (general_linear_regression): Use QR
 	factorization with refinement.
 
diff --git a/NEWS b/NEWS
index ea8a207..5f77d8d 100644
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ goffice 0.8.4:
 Morten:
 	* Regression fixes.
 	* Improve linear regression accuracy.
+	* Plug leaks.
 
 --------------------------------------------------------------------------
 goffice 0.8.3:
@@ -193,7 +194,7 @@ goffice 0.7.8:
 
 Andreas:
 	* Add some odf GOFormat output utilities.
-	* Handle scale attributes in markup.	
+	* Handle scale attributes in markup.
 
 Morten:
 	* Add functions to generate number formats.
@@ -350,7 +351,7 @@ Jody:
 	* Tune bubble size calc to be closer to other implementions.
 
 Rob Staudinger:
-	* Use plain menu items for toolbar overflow image menu item proxies, 
+	* Use plain menu items for toolbar overflow image menu item proxies,
 	so they are displayed correctly with gtk-menu-images=0. [#537541]
 
 --------------------------------------------------------------------------
@@ -461,7 +462,7 @@ Jody:
 
 Jon KÃ¥re:
 	* Fix format selector crash [#475136].
-	* Don't	close image save as dialog after wrong extension. [#420451]	
+	* Don't	close image save as dialog after wrong extension. [#420451]
 
 Morten:
 	* Add function to test if a format has an hour field.
@@ -518,7 +519,7 @@ goffice 0.3.8:
 
 Emmanuel:
 	* Fix alignement of rotated axis labels. [#343507]
-	
+
 Morten:
 	* Add preconditions to text combo widget's API functions.
 	* Unicode-normalize regexps patterns.
@@ -605,7 +606,7 @@ Dom:
 
 Jon KÃ¥re:
         * Use info from gdk-pixbuf to convert from MIME type to image
-	  format. 
+	  format.
         * Fix bug which hid file save format selector .
         * go_gtk_file_sel_dialog no longer unhides all hidden widgets
 	  when displaying dialog.
@@ -628,7 +629,7 @@ Emmanuel Pacaud:
 	* Add rotation support for polar plots.
 	* Fix display of log axis minor ticks [#341880].
 	* Add new ?pi/? format, mainly for polar plot use.
-	* Fix bar/col plots when using log scale. 
+	* Fix bar/col plots when using log scale.
 	* Fix a crash when polar plot width or height == 0 [#349238].
 	* Swith to cairo renderer [#314211] [#310322].
 	* New pattern, gradient, color and line selectors [#152673].
@@ -670,10 +671,10 @@ Emmanuel Pacaud:
 	* Implement stretched image pattern in cairo renderer.
 	* Fix axis label position.
 	* Improve scientific format, add an engineering mode and a
-	special format with markup for display of exponent as 
+	special format with markup for display of exponent as
 	superscript (e.g. 10²) (Currently only used by graph engine when
 	using cairo renderer).
-	
+
 Ivan Wong :
 	* [Win32] Only export symbols which are in the public headers.
 	  [#307356]
@@ -791,7 +792,7 @@ Emmanuel Pacaud:
 	add a GUI for these properties [#124322].
 	* Fix some libglade warnings [#305010].
 	* Fix contour plots axes.
-	
+
 Ivan, Y.C. Wong:
 	* Fix encoding bug when open file with non-ascii name in shell.
 	* Fix Mime Type detection on Win32 [#304074].
@@ -815,7 +816,7 @@ Jody:
 Morten:
 	* Fix theme bug.  [#303707]
 	* Fix insert-image criticals.  [#305009]
-	
+
 --------------------------------------------------------------------------
 goffice 0.0.1
 
diff --git a/goffice/component/go-component-factory.c b/goffice/component/go-component-factory.c
index 02d8af9..9d2d03b 100644
--- a/goffice/component/go-component-factory.c
+++ b/goffice/component/go-component-factory.c
@@ -152,7 +152,7 @@ go_component_type_service_read_xml (GOPluginService * service, xmlNode * tree,
 										mime_type->component_type_name);
 				GSList *old_mime = g_slist_find_custom (old_service->mime_types, name, (GCompareFunc) strcmp);
 				g_free (old_mime->data);
-				old_service->mime_types = g_slist_remove_link (old_service->mime_types, old_mime);
+				old_service->mime_types = g_slist_delete_link (old_service->mime_types, old_mime);
 				g_free (mime_type->component_type_name);
 				mime_type->component_type_name = g_strdup (service->id);
 				mime_type->priority = i;
@@ -185,7 +185,7 @@ go_component_type_service_deactivate (GOPluginService *service, GOErrorInfo **re
 	while (l) {
 		GSList *mime_type = g_slist_find_custom (mime_types_names, l->data, (GCompareFunc) strcmp);
 		g_free (mime_type->data);
-		mime_types_names = g_slist_remove_link (mime_types_names, mime_type);
+		mime_types_names = g_slist_delete_link (mime_types_names, mime_type);
 		l = l->next;
 	}
 	service->is_active = FALSE;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]