[giggle] Add a warning dialog to fill the fields of clone dialog
- From: Javier Jardón <jjardon src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [giggle] Add a warning dialog to fill the fields of clone dialog
- Date: Mon, 10 May 2010 20:38:14 +0000 (UTC)
commit a2a199af9f105f23ae4dac478f52abd5b17870d2
Author: Javier Jardón <jjardon gnome org>
Date: Mon May 10 22:35:24 2010 +0200
Add a warning dialog to fill the fields of clone dialog
Reported by Å?ukasz JernaÅ? here:
https://bugzilla.gnome.org/show_bug.cgi?id=618068
src/giggle-clone-dialog.c | 21 +++++++++++++++++++--
1 files changed, 19 insertions(+), 2 deletions(-)
---
diff --git a/src/giggle-clone-dialog.c b/src/giggle-clone-dialog.c
index 8a10aa5..bbad111 100644
--- a/src/giggle-clone-dialog.c
+++ b/src/giggle-clone-dialog.c
@@ -39,7 +39,7 @@ entry_has_input (GtkWidget *entry)
static gboolean
input_is_valid (GiggleCloneDialog *dialog)
{
- gboolean is_valid;
+ gboolean is_valid = FALSE;
is_valid = entry_has_input (dialog->priv->remote_entry) &&
entry_has_input (dialog->priv->local_entry);
@@ -141,6 +141,20 @@ clone_repository_finished (GiggleGit *git,
}
static void
+warning_dialog (GtkWindow *parent)
+{
+ GtkWidget *widget;
+
+ widget = gtk_message_dialog_new (parent,
+ GTK_DIALOG_DESTROY_WITH_PARENT,
+ GTK_MESSAGE_ERROR,
+ GTK_BUTTONS_CLOSE,
+ "You must fill out both fields of dialogue");
+ gtk_dialog_run (GTK_DIALOG (widget));
+ gtk_widget_destroy (widget);
+}
+
+static void
clone_repository (GiggleCloneDialog *dialog, GtkButton *button)
{
GiggleJob *job;
@@ -148,7 +162,10 @@ clone_repository (GiggleCloneDialog *dialog, GtkButton *button)
const gchar *repo, *name;
gchar *base;
- g_assert (input_is_valid (dialog));
+ if (input_is_valid (dialog) == FALSE) {
+ warning_dialog (GTK_WINDOW (dialog));
+ return;
+ }
gtk_widget_set_sensitive (GTK_WIDGET (button), FALSE);
gtk_widget_set_sensitive (dialog->priv->remote_entry, FALSE);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]