[gnumeric] sheet duplicate: copy values of non-corner array cells.



commit c158b818461eeb8348551ad160ae0e143863d116
Author: Morten Welinder <terra gnome org>
Date:   Mon May 3 09:57:12 2010 -0400

    sheet duplicate: copy values of non-corner array cells.

 ChangeLog   |    2 +-
 NEWS        |    2 +-
 src/sheet.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index e5d5778..e8bb086 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,7 +2,7 @@
 
 	* src/sheet.c (cb_sheet_cell_copy): Use gnm_cell_assign_value, not
 	gnm_cell_set_value, for non-corner array cells.  Fixes part of
-	#617469.
+	#617469.  Copy the value!  Fixes part of #617469.
 
 2010-05-02  Morten Welinder  <terra gnome org>
 
diff --git a/NEWS b/NEWS
index 884a718..b4f65b1 100644
--- a/NEWS
+++ b/NEWS
@@ -27,7 +27,7 @@ Morten:
 	* Fix problem parsing comples numbers.
 	* Improve error handle for complex functions.
 	* Improve IMPOWER.
-	* Fix sheet duplicate criticals.  [Part of #617469]
+	* Fix sheet duplicate bugs.  [Part of #617469]
 
 --------------------------------------------------------------------------
 Gnumeric 1.10.2
diff --git a/src/sheet.c b/src/sheet.c
index 8b9913b..f547641 100644
--- a/src/sheet.c
+++ b/src/sheet.c
@@ -5422,7 +5422,7 @@ cb_sheet_cell_copy (gpointer unused, gpointer key, gpointer new_sheet_param)
 					GnmCell *out = sheet_cell_fetch (dst,
 						cell->pos.col + i,
 						cell->pos.row + j);
-					gnm_cell_assign_value (out, in->value);
+					gnm_cell_assign_value (out, value_dup (in->value));
 				}
 	} else {
 		GnmCell *new_cell = sheet_cell_create (dst, cell->pos.col, cell->pos.row);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]