[galeon] Fixed a bunch of format string warnings



commit 7074d1571f2cfbe6cac2aa2d034d9e2b392f35db
Author: Fabio Bonelli <fabiob src gnome org>
Date:   Sun May 2 17:05:39 2010 +0200

    Fixed a bunch of format string warnings
    
    Patch galeon-2.0.7-fix-str-fmt.patch from Fedora.

 libegg/egg-recent-model.c                |    2 +-
 mozilla/GtkNSSSecurityWarningDialogs.cpp |    4 ++--
 utils/gul-download.c                     |    4 ++--
 utils/gul-gui.c                          |    1 +
 4 files changed, 6 insertions(+), 5 deletions(-)
---
diff --git a/libegg/egg-recent-model.c b/libegg/egg-recent-model.c
index 76a20d4..86ce6e7 100644
--- a/libegg/egg-recent-model.c
+++ b/libegg/egg-recent-model.c
@@ -735,7 +735,7 @@ egg_recent_model_read (EggRecentModel *model, FILE *file)
 	error = NULL;
 	if (!g_markup_parse_context_parse (ctx, content, strlen (content),
 					   &error)) {
-		g_warning (error->message);
+		g_warning ("%s", error->message);
 		g_error_free (error);
 		error = NULL;
 		goto out;
diff --git a/mozilla/GtkNSSSecurityWarningDialogs.cpp b/mozilla/GtkNSSSecurityWarningDialogs.cpp
index 1beb507..705e745 100644
--- a/mozilla/GtkNSSSecurityWarningDialogs.cpp
+++ b/mozilla/GtkNSSSecurityWarningDialogs.cpp
@@ -255,12 +255,12 @@ GtkNSSSecurityWarningDialogs::DoDialog (nsIInterfaceRequestor *aContext,
 	GtkDialogFlags flags = parent ? (GtkDialogFlags)0 : GTK_DIALOG_MODAL;
 #if GTK_CHECK_VERSION(2,6,0)
 	GtkWidget *dialog = gtk_message_dialog_new (GTK_WINDOW (parent), flags,
-						    aType, aButtons, aPrimary);
+						    aType, aButtons, "%s", aPrimary);
 
         if (aSecondary)
         {
                 gtk_message_dialog_format_secondary_markup
-                        (GTK_MESSAGE_DIALOG (dialog), aSecondary);
+                        (GTK_MESSAGE_DIALOG (dialog), "%s", aSecondary);
         }
 
 #else
diff --git a/utils/gul-download.c b/utils/gul-download.c
index 415f814..9f47801 100644
--- a/utils/gul-download.c
+++ b/utils/gul-download.c
@@ -283,7 +283,7 @@ gul_download_save_url_with_command_line (const gchar *url, const gchar *command,
 
 		text = g_strdup_printf (_("Failed to execute download "
 					  "command."));
-		g_warning (text);
+		g_warning ("%s", text);
 		g_free (text);
 	}
 }
@@ -345,7 +345,7 @@ gul_download_gtm_add_url (const gchar *url, gchar *dir, gboolean disable_proxy,
 					  "\thttp://gtm.sourceforge.net";));
 		/* dialog = gnome_error_dialog (text); */
 		/* gnome_dialog_run_and_close (GNOME_DIALOG (dialog)); */
-		g_warning(text);
+		g_warning("%s",text);
 		g_free (text);
 	}
   
diff --git a/utils/gul-gui.c b/utils/gul-gui.c
index e606b26..c036ae3 100644
--- a/utils/gul-gui.c
+++ b/utils/gul-gui.c
@@ -793,6 +793,7 @@ gul_gui_help (GtkWindow *parent, const char *file, const char *link_id)
 					GTK_RESPONSE_OK,
 					NULL);
 		hig_alert_set_secondary_printf (HIG_ALERT (dialog),
+						"%s",
 						error->message);
 		g_signal_connect (G_OBJECT (dialog), "response",
 				  G_CALLBACK (gtk_widget_destroy),



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]