[tracker/miner-web-review: 66/74] tracker-extract: Check for return value in GStreamer extractor

[Adrien Bustany <abustany src gnome org>]

commit dc2940e1bcf34f5c9ad1cd4b6b0f9fc42991100c
Author: Philip Van Hoof <philip codeminded be>
Date:   Fri Feb 26 12:17:00 2010 +0100

    tracker-extract: Check for return value in GStreamer extractor

 src/tracker-extract/tracker-extract-gstreamer.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
---
diff --git a/src/tracker-extract/tracker-extract-gstreamer.c b/src/tracker-extract/tracker-extract-gstreamer.c
index 682b3fd..0af164d 100644
--- a/src/tracker-extract/tracker-extract-gstreamer.c
+++ b/src/tracker-extract/tracker-extract-gstreamer.c
@@ -266,15 +266,12 @@ add_fraction_gst_tag (TrackerSparqlBuilder         *metadata,
 
 	ret = gst_tag_list_copy_value (&n, tag_list, tag);
 
-	/* Hack to avoid criticals, remove when NB# 158636 is fixed */
-	if (GST_VALUE_HOLDS_FRACTION (&n)) {
+	if (ret) {
 		f = (gfloat)gst_value_get_fraction_numerator (&n)/
 		gst_value_get_fraction_denominator (&n);
 
-		if (ret) {
-			tracker_sparql_builder_predicate (metadata, key);
-			tracker_sparql_builder_object_double (metadata, (gdouble) f);
-		}
+		tracker_sparql_builder_predicate (metadata, key);
+		tracker_sparql_builder_object_double (metadata, (gdouble) f);
 	}
 }