[gnome-terminal] Fix a crash in tab DND



commit bc03b1f43077b594ca0405470e322731ea38de4b
Author: Matthias Clasen <mclasen redhat com>
Date:   Mon Jun 28 12:25:06 2010 -0400

    Fix a crash in tab DND
    
    The screen container is no longer a direct parent of the screen,
    so we cannot call gtk_container_remove (screen_container, screen).
    At least not without an assertion from GTK+...
    
    Bug 623053

 src/terminal-window.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/src/terminal-window.c b/src/terminal-window.c
index 162d997..8114569 100644
--- a/src/terminal-window.c
+++ b/src/terminal-window.c
@@ -2428,7 +2428,7 @@ terminal_window_move_screen (TerminalWindow *source_window,
   terminal_window_remove_screen (source_window, screen);
     
   /* Now we can safely remove the screen from the container and let the container die */
-  gtk_container_remove (GTK_CONTAINER (screen_container), GTK_WIDGET (screen));
+  gtk_container_remove (GTK_CONTAINER (gtk_widget_get_parent (GTK_WIDGET (screen))), GTK_WIDGET (screen));
   g_object_unref (screen_container);
 
   terminal_window_add_screen (dest_window, screen, dest_position);



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]