[evolution-data-server] Bug 622822 - Fix failure return from nntp_folder_refresh_info_online()
- From: David Woodhouse <dwmw2 src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] Bug 622822 - Fix failure return from nntp_folder_refresh_info_online()
- Date: Mon, 28 Jun 2010 11:10:03 +0000 (UTC)
commit 4d907e246f48586e2bf55072de194fff3066e3b4
Author: David Woodhouse <David Woodhouse intel com>
Date: Sun Jun 27 08:37:55 2010 +0100
Bug 622822 - Fix failure return from nntp_folder_refresh_info_online()
When invoked with no fmt argument, camel_nntp_command() is only supposed
to select the folder and return zero.
Since commit 08cfec3e we have been interpreting that zero as FALSE, and
this is what causes nntp folders to appear empty as refresh_info appears
to fail.
camel/providers/nntp/camel-nntp-folder.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/camel/providers/nntp/camel-nntp-folder.c b/camel/providers/nntp/camel-nntp-folder.c
index ae394dc..67c8d6d 100644
--- a/camel/providers/nntp/camel-nntp-folder.c
+++ b/camel/providers/nntp/camel-nntp-folder.c
@@ -104,7 +104,9 @@ nntp_folder_refresh_info_online (CamelFolder *folder,
camel_service_lock (CAMEL_SERVICE (nntp_store), CAMEL_SERVICE_REC_CONNECT_LOCK);
- success = camel_nntp_command (
+ /* When invoked with no fmt, camel_nntp_command() just selects the folder
+ and should return zero. */
+ success = !camel_nntp_command (
nntp_store, ex, nntp_folder, &line, NULL);
if (camel_folder_change_info_changed(nntp_folder->changes)) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]