[evolution-data-server] Disable the special-case for the selected folder in refresh_info
- From: David Woodhouse <dwmw2 src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution-data-server] Disable the special-case for the selected folder in refresh_info
- Date: Thu, 24 Jun 2010 13:12:49 +0000 (UTC)
commit b44f64b984519395026fab12087478245d4d23d4
Author: David Woodhouse <David Woodhouse intel com>
Date: Thu Jun 24 14:09:45 2010 +0100
Disable the special-case for the selected folder in refresh_info
It will make us miss messages on servers like Groupwise which don't give
unsolicited change notices; we really _do_ need to issue STATUS there,
even though it's explicitly forbidden by RFC3501 do so. Or SEARCH UNSEEN.
But the logic is broken anyway -- what is the currently-selected folder NOW
may not be the currently-selected folder by the time our STATUS command hits
the front of the queue anyway, so we do still end up doing STATUS on the
current folder sometimes. Needs more thought.
camel/providers/imapx/camel-imapx-server.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index 8dfda07..7f3224b 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -3612,9 +3612,11 @@ imapx_job_refresh_info_start (CamelIMAPXServer *is, CamelIMAPXJob *job)
if (camel_exception_is_set (job->ex))
goto done;
+#if 0 /* There are issues with this still; continue with the buggy behaviour
+ where we issue STATUS on the current folder, for now...*/
if (is->select && !strcmp(full_name, is->select))
is_selected = TRUE;
-
+#endif
total = camel_folder_summary_count (folder->summary);
/* We don't have valid unread count or modseq for currently-selected server
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]