[glib] GDBusProxy: Don't warn when calling methods on other interfaces
- From: David Zeuthen <davidz src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] GDBusProxy: Don't warn when calling methods on other interfaces
- Date: Tue, 22 Jun 2010 21:52:08 +0000 (UTC)
commit 6920e503e637e70a44f7baf899de4bd171534d39
Author: David Zeuthen <davidz redhat com>
Date: Tue Jun 22 17:48:35 2010 -0400
GDBusProxy: Don't warn when calling methods on other interfaces
If we know the expected interface (e.g. :g-interface-info is set),
then we always warned when calling a method on a different
interface. Don't do that, there's no way the expected interface can
know anything about this method.
Signed-off-by: David Zeuthen <davidz redhat com>
gio/gdbusproxy.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/gio/gdbusproxy.c b/gio/gdbusproxy.c
index 1629c13..4d658a1 100644
--- a/gio/gdbusproxy.c
+++ b/gio/gdbusproxy.c
@@ -2215,8 +2215,10 @@ g_dbus_proxy_call (GDBusProxy *proxy,
g_object_set_data_full (G_OBJECT (simple), "-gdbus-proxy-method-name", g_strdup (target_method_name), g_free);
- /* Just warn here */
- expected_method_info = lookup_method_info_or_warn (proxy, target_method_name);
+ /* Warn if method is unexpected (cf. :g-interface-info) */
+ expected_method_info = NULL;
+ if (!was_split)
+ expected_method_info = lookup_method_info_or_warn (proxy, target_method_name);
if (expected_method_info)
reply_type = _g_dbus_compute_complete_signature (expected_method_info->out_args);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]