[bug-buddy] Do not call old log_handler if it is not glib's default See https://bugzilla.gnome.org/show_bug.cgi?
- From: Fernando Herrera de las Heras <fherrera src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [bug-buddy] Do not call old log_handler if it is not glib's default See https://bugzilla.gnome.org/show_bug.cgi?
- Date: Tue, 22 Jun 2010 20:21:22 +0000 (UTC)
commit 475fa5697d0aad6883318e9c51af81f51c9030e4
Author: Fernando Herrera <fherrera onirica com>
Date: Tue Jun 22 22:18:23 2010 +0200
Do not call old log_handler if it is not glib's default
See https://bugzilla.gnome.org/show_bug.cgi?id=622068
segv_handler/gnome-segvhanlder.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
---
diff --git a/segv_handler/gnome-segvhanlder.c b/segv_handler/gnome-segvhanlder.c
index de64df5..ae3196e 100644
--- a/segv_handler/gnome-segvhanlder.c
+++ b/segv_handler/gnome-segvhanlder.c
@@ -284,6 +284,13 @@ gtk_module_init (int *argc, char** argv[])
sigaction(SIGBUS, setptr, NULL);
old_handler = g_log_set_default_handler (bug_buddy_log_handler, NULL);
+
+ /* We cannot call previous log handlers other than glib's default
+ * because we don't know its previous user_data and they may rely on it
+ * See https://bugzilla.gnome.org/show_bug.cgi?id=622068 */
+ if (old_handler != g_log_default_handler) {
+ old_handler = NULL;
+ }
}
return 0;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]