[krb5-auth-dialog] Free my_creds unconditionally



commit e91acf3273856f07a594403109ddc8edbdad651e
Author: Guido Günther <agx sigxcpu org>
Date:   Fri Jun 18 19:37:41 2010 +0200

    Free my_creds unconditionally
    
    to avoid leaks.

 src/ka-dialog.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
---
diff --git a/src/ka-dialog.c b/src/ka-dialog.c
index 1eb7faf..468b185 100644
--- a/src/ka-dialog.c
+++ b/src/ka-dialog.c
@@ -232,8 +232,8 @@ credentials_expiring_real (KaApplet* applet)
 		ka_applet_set_tgt_renewable(applet, TRUE);
 	}
 
-	krb5_free_cred_contents (kcontext, &my_creds);
 out:
+	krb5_free_cred_contents (kcontext, &my_creds);
 	ka_applet_update_status(applet, creds_expiry);
 	return retval;
 }
@@ -859,6 +859,7 @@ ka_renew_credentials (KaApplet* applet)
 
 	retval = ka_get_tgt_from_ccache (kcontext, &my_creds);
 	if (!retval) {
+		krb5_free_cred_contents (kcontext, &my_creds);
 		krb5_cc_close (kcontext, ccache);
 		return -1;
 	}
@@ -867,7 +868,7 @@ ka_renew_credentials (KaApplet* applet)
 	set_options_from_creds (applet, kcontext, &my_creds, &opts);
 
 	if (ka_applet_get_tgt_renewable(applet)) {
-
+		krb5_free_cred_contents (kcontext, &my_creds);
 		retval = get_renewed_creds (kcontext, &my_creds, kprincipal, ccache, NULL);
 		if (retval)
 			goto out;



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]