[evolution-data-server/gnome-2-30] Bug 621740 - Fix double-free of is->literal in cancel_all_jobs()



commit 6cc1800d92024bcd7c75d3b15679ac33e4868580
Author: David Woodhouse <David Woodhouse intel com>
Date:   Thu Jun 17 00:09:15 2010 +0100

    Bug 621740 - Fix double-free of is->literal in cancel_all_jobs()
    
    The command which is is->literal is either on the queue or owned somewhere
    else; there's no need for it to be freed in cancel_all_jobs() too.

 camel/providers/imapx/camel-imapx-server.c |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
---
diff --git a/camel/providers/imapx/camel-imapx-server.c b/camel/providers/imapx/camel-imapx-server.c
index 8fbf22e..058d4ee 100644
--- a/camel/providers/imapx/camel-imapx-server.c
+++ b/camel/providers/imapx/camel-imapx-server.c
@@ -1666,7 +1666,7 @@ imapx_command_run(CamelIMAPXServer *is, CamelIMAPXCommand *ic)
 		imapx_step(is, ic->ex);
 	} while (ic->status == NULL && !camel_exception_is_set (ic->ex));
 	if (is->literal == ic)
-		is->literal = NULL; 
+		is->literal = NULL;
 
 	QUEUE_LOCK(is);
 	camel_dlist_remove((CamelDListNode *)ic);
@@ -4094,11 +4094,6 @@ imapx_disconnect (CamelIMAPXServer *is)
 		is->select_pending = NULL;
 	}
 
-	if (is->literal) {
-		camel_imapx_command_free (is->literal);
-		is->literal = NULL;
-	}
-
 	if (is->cinfo) {
 		imapx_free_capability(is->cinfo);
 		is->cinfo = NULL;	



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]