[memprof: 59/76] server.c: Fix warning the use of `mktemp' is dangerous



commit eeb603239c1ad561b95e26481283a837790d9710
Author: Juan A. Suarez Romero <jasuarez igalia com>
Date:   Fri Dec 4 10:00:53 2009 +0000

    server.c: Fix warning the use of `mktemp' is dangerous
    
    Instead of using 'mktemp', use 'mkstemp', which is safer.

 src/server.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/server.c b/src/server.c
index 0f7c45e..d771a4a 100644
--- a/src/server.c
+++ b/src/server.c
@@ -36,7 +36,7 @@
 
 /* If USE_SOCKET_DIRECTORY is defined, then the temporary sockets will
  * be created as /tmp/memprof.UID/server.PID. Otherwise, they will
- * be created as /tmp/memprof.XXXXXX. Despite calling mktemp(), the
+ * be created as /tmp/memprof.XXXXXX. Despite calling mkstemp(), the
  * latter should be completely safe, because unix domain socket creation
  * will fail with EADDRINUSE if the file already exists.
  */
@@ -435,8 +435,8 @@ create_control_socket (MPServer *server)
 		
 #else  /* !USE_SOCKET_DIRECTORY */
 	server->socket_path = g_build_filename (g_get_tmp_dir(), SOCKET_TEMPLATE, NULL);
-	if (strlen(mktemp (server->socket_path)) == 0)
-		fatal ("mktemp: %s\n", g_strerror (errno));
+	if (mkstemp (server->socket_path) == -1)
+		fatal ("mkstemp: %s\n", g_strerror (errno));
 #endif /* USE_SOCKET_DIRECTORY */
 
 	strncpy (addr.sun_path, server->socket_path, sizeof (addr.sun_path));



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]