[glibmm/glibmm-3maybe] Add default signal handlers that couldn't be added before breaking ABI.



commit 112a81f079541a819fb49dc4f079478f60cc3365
Author: Murray Cumming <murrayc murrayc com>
Date:   Tue Jun 8 16:42:10 2010 +0200

    Add default signal handlers that couldn't be added before breaking ABI.
    
    * gio/src/drive.hg:
    * gio/src/mount.hg:
    * gio/src/mountoperation.hg:
    * gio/src/resolver.hg:
    * gio/src/themedicon.hg:
    * gio/src/volumemonitor.hg:
    * glib/src/checksum.hg: Remove the no_default_handler parameter from
        _WRAP_SIGNAL() calls.

 ChangeLog                 |   13 +++++++++++++
 gio/src/drive.hg          |    8 ++++----
 gio/src/mount.hg          |    2 +-
 gio/src/mountoperation.hg |    3 +--
 gio/src/resolver.hg       |    3 +--
 gio/src/themedicon.hg     |    6 +++---
 gio/src/volumemonitor.hg  |   10 ++++------
 glib/src/checksum.hg      |    4 +---
 8 files changed, 28 insertions(+), 21 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index c5657c3..6cf54a6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,18 @@
 2010-06-08  Murray Cumming  <murrayc murrayc com>
 
+	Add default signal handlers that couldn't be added before breaking ABI.
+
+	* gio/src/drive.hg:
+	* gio/src/mount.hg:
+	* gio/src/mountoperation.hg:
+	* gio/src/resolver.hg:
+	* gio/src/themedicon.hg:
+	* gio/src/volumemonitor.hg:
+	* glib/src/checksum.hg: Remove the no_default_handler parameter from
+    _WRAP_SIGNAL() calls.
+
+2010-06-08  Murray Cumming  <murrayc murrayc com>
+
 	Remove deprecated API.
 
     * gio/src/asyncresult.hg:
diff --git a/gio/src/drive.hg b/gio/src/drive.hg
index 872dd4d..33c3292 100644
--- a/gio/src/drive.hg
+++ b/gio/src/drive.hg
@@ -151,18 +151,18 @@ public:
 
   /** @newin{2,20}
    */
-  _WRAP_SIGNAL(void changed(), changed, no_default_handler)
+  _WRAP_SIGNAL(void changed(), changed)
 
   /** @newin{2,20}
    */
-  _WRAP_SIGNAL(void disconnected(), disconnected, no_default_handler)
+  _WRAP_SIGNAL(void disconnected(), disconnected)
 
   /** @newin{2,20}
    */
-  _WRAP_SIGNAL(void eject_button(), eject_button, no_default_handler)
+  _WRAP_SIGNAL(void eject_button(), eject_button)
 
   /** @newin{2,22} */
-  _WRAP_SIGNAL(void stop_button(), stop_button, no_default_handler)
+  _WRAP_SIGNAL(void stop_button(), stop_button)
 
   //_WRAP_VFUNC(Glib::ustring get_name() const, get_name)
   //Careful of ref-counting: //_WRAP_VFUNC(Glib::RefPtr<Icon> get_icon() const, get_icon)
diff --git a/gio/src/mount.hg b/gio/src/mount.hg
index 987b031..dab5171 100644
--- a/gio/src/mount.hg
+++ b/gio/src/mount.hg
@@ -215,7 +215,7 @@ public:
 
   _WRAP_SIGNAL(void changed(), changed)
   _WRAP_SIGNAL(void unmounted(), unmounted)
-  _WRAP_SIGNAL(void pre_unmount(), pre_unmount, no_default_handler)
+  _WRAP_SIGNAL(void pre_unmount(), pre_unmount)
 
   //There are no properties.
 };
diff --git a/gio/src/mountoperation.hg b/gio/src/mountoperation.hg
index 03350dc..1a60ce9 100644
--- a/gio/src/mountoperation.hg
+++ b/gio/src/mountoperation.hg
@@ -87,8 +87,7 @@ public:
 
   _WRAP_SIGNAL(void reply(MountOperationResult result), reply)
 
-  //TODO: Remove no_default_handler when we can break ABI:
-  _WRAP_SIGNAL(void aborted(), aborted, no_default_handler)
+  _WRAP_SIGNAL(void aborted(), aborted)
 
   //TODO: The array of char* is not very pleasant to wrap:
   //_WRAP_SIGNAL( void show_processes(const Glib::ustring& message, GArray* processes, const gchar *choices[]);
diff --git a/gio/src/resolver.hg b/gio/src/resolver.hg
index f3ffe43..bb8cd51 100644
--- a/gio/src/resolver.hg
+++ b/gio/src/resolver.hg
@@ -83,8 +83,7 @@ public:
   _WRAP_METHOD(ListHandle_SrvTarget lookup_service_finish(const Glib::RefPtr<AsyncResult>& result), g_resolver_lookup_service_finish, errthrow)
 
 
-  //TODO: Remove no_default_handler when we can break ABI:
-  _WRAP_SIGNAL(void reload(), reload, no_default_handler)
+  _WRAP_SIGNAL(void reload(), reload)
 };
 
 std::string hostname_to_ascii (const Glib::ustring& hostname);
diff --git a/gio/src/themedicon.hg b/gio/src/themedicon.hg
index b7260a9..0fd667a 100644
--- a/gio/src/themedicon.hg
+++ b/gio/src/themedicon.hg
@@ -69,10 +69,10 @@ public:
 
   //There are no signals.
 
-  //TODO: Remove these when we can break ABI. They are write-only and construct-only.
-  _WRAP_PROPERTY("name", std::string)
+  //All these properties are write-only and construct-only.
+  //_WRAP_PROPERTY("name", std::string)
   //An array: This is awkward to wrap_WRAP_PROPERTY("names", )
-  _WRAP_PROPERTY("use-default-fallbacks", bool)
+  //_WRAP_PROPERTY("use-default-fallbacks", bool)
 };
 
 } // namespace Gio
diff --git a/gio/src/volumemonitor.hg b/gio/src/volumemonitor.hg
index 3a9a1d2..b3ba5ba 100644
--- a/gio/src/volumemonitor.hg
+++ b/gio/src/volumemonitor.hg
@@ -28,8 +28,8 @@ namespace Gio
 {
 
 /** Monitors a file or directory for changes.
- * VolumeMonitor is for listing the user-interesting devices and volumes on the 
- * computer. In other words, what a file selector or file manager would show in 
+ * VolumeMonitor is for listing the user-interesting devices and volumes on the
+ * computer. In other words, what a file selector or file manager would show in
  * a sidebar.
  *
  * @newin{2,16}
@@ -73,9 +73,8 @@ public:
   _WRAP_SIGNAL(void drive_disconnected(const Glib::RefPtr<Drive>& drive), drive_disconnected)
   _WRAP_SIGNAL(void drive_changed(const Glib::RefPtr<Drive>& drive), drive_changed)
 
-  //TODO: Remove no_default_handler when we can break ABI:
-  _WRAP_SIGNAL(void drive_eject_button(const Glib::RefPtr<Drive>& drive), drive_eject_button, no_default_handler)
-  _WRAP_SIGNAL(void drive_stop_button(const Glib::RefPtr<Drive>& drive), drive_stop_button, no_default_handler)
+  _WRAP_SIGNAL(void drive_eject_button(const Glib::RefPtr<Drive>& drive), drive_eject_button)
+  _WRAP_SIGNAL(void drive_stop_button(const Glib::RefPtr<Drive>& drive), drive_stop_button)
 
   gboolean (*is_supported)          (void);
 
@@ -93,4 +92,3 @@ public:
 };
 
 } // namespace Gio
-
diff --git a/glib/src/checksum.hg b/glib/src/checksum.hg
index e9f599f..57775ba 100644
--- a/glib/src/checksum.hg
+++ b/glib/src/checksum.hg
@@ -77,9 +77,7 @@ public:
 
   _WRAP_METHOD(void reset(), g_checksum_reset)
   
-  //TODO: length should really be gssize, not gsize, when we can break ABI:
-#m4 _CONVERSION(`gsize',`gssize',`(gssize)($3)')
-  _WRAP_METHOD(void update(const guchar* data, gsize length), g_checksum_update)
+  _WRAP_METHOD(void update(const guchar* data, gssize length), g_checksum_update)
 
   /** Feeds data into an existing Checksum.
    * The checksum must still be open, that is get_string() or get_digest() must not have been called on the checksum.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]