[gnome-control-center/wip/universal-access: 2/14] shell: don't call gtk_widget_show_all on the new panel



commit 081b8a2c6bd2af9d29d59d6d100e4f2e81e3ffa7
Author: Thomas Wood <thomas wood intel com>
Date:   Thu Jun 3 11:56:28 2010 +0100

    shell: don't call gtk_widget_show_all on the new panel
    
    Don't call gtk_widget_show_all when loading a panel as there may be widgets
    that the panel does not want to be visible initially.

 panels/network/gnome-network-properties.ui |    1 +
 shell/gnome-control-center.c               |    6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)
---
diff --git a/panels/network/gnome-network-properties.ui b/panels/network/gnome-network-properties.ui
index 4977ae7..5143b04 100644
--- a/panels/network/gnome-network-properties.ui
+++ b/panels/network/gnome-network-properties.ui
@@ -18,6 +18,7 @@
             <property name="orientation">vertical</property>
             <child>
               <object class="GtkAlignment" id="alignment1">
+                <property name="visible">True</property>
                 <property name="xscale">0</property>
                 <child>
                   <object class="GtkHBox" id="hbox2">
diff --git a/shell/gnome-control-center.c b/shell/gnome-control-center.c
index 554f1e6..b37ab2d 100644
--- a/shell/gnome-control-center.c
+++ b/shell/gnome-control-center.c
@@ -130,14 +130,16 @@ activate_panel (GnomeControlCenter *shell,
           gtk_container_add (GTK_CONTAINER (box), panel);
 
           /* switch to the new panel */
-          i = gtk_notebook_append_page (GTK_NOTEBOOK (priv->notebook), box, NULL);
-          gtk_widget_show_all (box);
+          i = gtk_notebook_append_page (GTK_NOTEBOOK (priv->notebook), box,
+                                        NULL);
+          gtk_widget_show (box);
           gtk_notebook_set_current_page (GTK_NOTEBOOK (priv->notebook), i);
 
           /* set the title of the window */
           gtk_window_set_title (GTK_WINDOW (priv->window), name);
           gtk_window_set_icon_name (GTK_WINDOW (priv->window), icon_name);
 
+          gtk_widget_show (panel);
           return;
         }
     }



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]