[glibmm] Gio::Settings: [get|set]_strv(): Rename to [get|set]_string_array().
- From: José Alburquerque <jaalburqu src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glibmm] Gio::Settings: [get|set]_strv(): Rename to [get|set]_string_array().
- Date: Wed, 2 Jun 2010 04:47:26 +0000 (UTC)
commit 8bb898cafe4d769414e0ad41dbd233721a2ffffd
Author: José Alburquerque <jaalburqu svn gnome org>
Date: Wed Jun 2 00:38:37 2010 -0400
Gio::Settings: [get|set]_strv(): Rename to [get|set]_string_array().
* gio/src/settings.ccg:
* gio/src/settings.hg ([get|set]_strv): Rename to *_string_array()
which is more readable.
ChangeLog | 8 ++++++++
gio/src/settings.ccg | 6 +++---
gio/src/settings.hg | 12 +++++-------
3 files changed, 16 insertions(+), 10 deletions(-)
---
diff --git a/ChangeLog b/ChangeLog
index d7cc453..aa12aea 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2010-06-02 José Alburquerque <jaalburqu svn gnome org>
+
+ Gio::Settings: [get|set]_strv(): Rename to [get|set]_string_array().
+
+ * gio/src/settings.ccg:
+ * gio/src/settings.hg ([get|set]_strv): Rename to *_string_array()
+ which is more readable.
+
2010-06-01 Jonathon Jongsma <jonathon quotidian org>
* configure.ac: use GLIB_GSETTINGS
diff --git a/gio/src/settings.ccg b/gio/src/settings.ccg
index a99c880..5b4eff0 100644
--- a/gio/src/settings.ccg
+++ b/gio/src/settings.ccg
@@ -9,15 +9,15 @@ Glib::RefPtr<Settings> Settings::create_with_context(const Glib::ustring& schema
return Glib::RefPtr<Settings>(new Settings(g_settings_new_with_context(schema.c_str(), context.c_str())));
}
-Glib::ArrayHandle<Glib::ustring> Settings::get_strv(const Glib::ustring& key)
- const
+Glib::ArrayHandle<Glib::ustring>
+ Settings::get_string_array(const Glib::ustring& key) const
{
gchar** result = g_settings_get_strv(const_cast<GSettings*>(gobj()),
key.c_str(), 0);
return Glib::ArrayHandle<Glib::ustring>(result, Glib::OWNERSHIP_DEEP);
}
-bool Settings::set_strv(const Glib::ustring& key,
+bool Settings::set_string_array(const Glib::ustring& key,
const Glib::ArrayHandle<Glib::ustring>& value)
{
return g_settings_set_strv(gobj(), key.c_str(), value.data(), value.size());
diff --git a/gio/src/settings.hg b/gio/src/settings.hg
index 51522f7..5d8c6f4 100644
--- a/gio/src/settings.hg
+++ b/gio/src/settings.hg
@@ -60,19 +60,17 @@ public:
_WRAP_METHOD(double get_double(const Glib::ustring& key) const, g_settings_get_double)
_WRAP_METHOD(void set_double(const Glib::ustring& key, double value), g_settings_set_double)
-
- //TODO: Rename strv to string_array() in these methods? murrayc
-
/** Gets the value that is stored at key in the settings.
- * It is a programmer error to pass a @a key that isn't valid for settings or
- * is not of type 'string array'.
+ * It is a programmer error to pass a @a key that isn't valid for settings
+ * or is not of type 'string array'.
*
* @param key The key to get the value for.
* @return a newly-allocated, <tt>0</tt>-terminated array of strings.
*
* @newin{2,26}
*/
- Glib::ArrayHandle<Glib::ustring> get_strv(const Glib::ustring& key) const;
+ Glib::ArrayHandle<Glib::ustring>
+ get_string_array(const Glib::ustring& key) const;
_IGNORE(g_settings_get_strv)
/** Sets @a key in the settings to @a value.
@@ -86,7 +84,7 @@ public:
*
* @newin{2,26}
*/
- bool set_strv(const Glib::ustring& key,
+ bool set_string_array(const Glib::ustring& key,
const Glib::ArrayHandle<Glib::ustring>& value);
_IGNORE(g_settings_set_strv)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]